fix: ClassTypingContext#isSameSignature for generic methods

[pvojtechovsky]

The method with this declaration

<U> void visitCtConditional(final CtConditional<U> conditional)

defined in class and inteface returned false for ClassTypingContext#isSameSignature(methodFromIface, methodFromClass).

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171021.224515-100

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	method spoon.reflect.declaration.CtMethod spoon.support.visitor.ClassTypingContext::adaptMethod(spoon.reflect.declaration.CtMethod)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171021.224515-100

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	method spoon.reflect.declaration.CtMethod spoon.support.visitor.ClassTypingContext::adaptMethod(spoon.reflect.declaration.CtMethod)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

[monperrus]

Indeed, there is a bug, thanks.

However, this bug fix is super hard to review because there are too many changes in the test.

The reason is that the test data (test classes and methods in this case) is changed (and not only added).

It's better to keep the same test classes/methods, and only add new ones to demonstrate the bug. Doing that, there is mostly new content in tests (as opposed to modified content), and at most a few well documented changed assertions (if the incorrect behavior was already specified and enforced).

[pvojtechovsky]

You are right. Now I did only minimum changes in existing test - because of change of useless hard to implement API method.
I also added new small test to reproduce problem.

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171023.182639-102

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	method spoon.reflect.declaration.CtMethod spoon.support.visitor.ClassTypingContext::adaptMethod(spoon.reflect.declaration.CtMethod)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

[pvojtechovsky]

I am done here

[monperrus]

thanks Pavel