review: refactor: move package spoon.generating.* from src/main to src/test
#1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
changed the title
spoon.generating.* from src/main to src/testspoon.generating.* from src/main to src/test
surli
changed the title
spoon.generating.* from src/main to src/testspoon.generating.* from src/main to src/test
|
rebase? |
Revapi Analysis resultsOld API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171031.203734-134 New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT Detected changes: 10. Change 1
Change 2
Change 3
Change 4
Change 5
Change 6
Change 7
Change 8
Change 9
Change 10
|
monperrus
reviewed
Oct 31, 2017
| @@ -415,7 +415,6 @@ public void testTest() throws Exception { | |||
| //Meta model classes doesn't have to follow test class naming conventions | |||
| continue; | |||
| } | |||
| assertTrue(t.getQualifiedName() + " is not clearly a test class, it should contain 'test' either in its package name or class name", t.getQualifiedName().matches("(?i:.*test.*)")); | |||
There was a problem hiding this comment.
this assertion is important :-)
we must move the classes into a test package.
|
@monperrus it's ready to merge |
Revapi Analysis resultsOld API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171106.110046-145 New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT Detected changes: 10. Change 1
Change 2
Change 3
Change 4
Change 5
Change 6
Change 7
Change 8
Change 9
Change 10
|
This was referenced Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1638