Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: feat: add missing create method in Factory #1659

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Oct 27, 2017

Fix #1272

@surli surli changed the title feat: add missing create method in Factory review: feat: add missing create method in Factory Oct 27, 2017
@spoon-bot
Copy link
Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171027.133921-114

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 26.

Change 1

Name Element
Old none
New method spoon.reflect.declaration.CtAnnotationType spoon.reflect.factory.Factory::createAnnotationType(java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 2

Name Element
Old none
New method spoon.reflect.declaration.CtAnnotationType spoon.reflect.factory.Factory::createAnnotationType(spoon.reflect.declaration.CtPackage, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 3

Name Element
Old none
New method spoon.reflect.declaration.CtClass spoon.reflect.factory.Factory::createClass(java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 4

Name Element
Old none
New method spoon.reflect.declaration.CtClass spoon.reflect.factory.Factory::createClass(spoon.reflect.declaration.CtClass<?>, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 5

Name Element
Old none
New method spoon.reflect.declaration.CtClass spoon.reflect.factory.Factory::createClass(spoon.reflect.declaration.CtPackage, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 6

Name Element
Old none
New method spoon.reflect.declaration.CtConstructor spoon.reflect.factory.Factory::createConstructor(spoon.reflect.declaration.CtClass, java.util.Set<spoon.reflect.declaration.ModifierKind>, java.util.List<spoon.reflect.declaration.CtParameter<?>>, java.util.Set<spoon.reflect.reference.CtTypeReference<? extends java.lang.Throwable>>)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 7

Name Element
Old none
New method spoon.reflect.declaration.CtConstructor spoon.reflect.factory.Factory::createConstructor(spoon.reflect.declaration.CtClass, java.util.Set<spoon.reflect.declaration.ModifierKind>, java.util.List<spoon.reflect.declaration.CtParameter<?>>, java.util.Set<spoon.reflect.reference.CtTypeReference<? extends java.lang.Throwable>>, spoon.reflect.code.CtBlock)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 8

Name Element
Old none
New method spoon.reflect.declaration.CtConstructor spoon.reflect.factory.Factory::createConstructor(spoon.reflect.declaration.CtClass, spoon.reflect.declaration.CtConstructor<?>)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 9

Name Element
Old none
New method spoon.reflect.declaration.CtConstructor spoon.reflect.factory.Factory::createConstructor(spoon.reflect.declaration.CtClass, spoon.reflect.declaration.CtMethod<?>)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 10

Name Element
Old none
New method spoon.reflect.declaration.CtEnum<?> spoon.reflect.factory.Factory::createEnum(java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 11

Name Element
Old none
New method spoon.reflect.declaration.CtEnum<?> spoon.reflect.factory.Factory::createEnum(spoon.reflect.declaration.CtPackage, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 12

Name Element
Old none
New method spoon.reflect.declaration.CtField spoon.reflect.factory.Factory::createField(spoon.reflect.declaration.CtType<?>, java.util.Set<spoon.reflect.declaration.ModifierKind>, spoon.reflect.reference.CtTypeReference, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 13

Name Element
Old none
New method spoon.reflect.declaration.CtField spoon.reflect.factory.Factory::createField(spoon.reflect.declaration.CtType<?>, java.util.Set<spoon.reflect.declaration.ModifierKind>, spoon.reflect.reference.CtTypeReference, java.lang.String, spoon.reflect.code.CtExpression)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 14

Name Element
Old none
New method spoon.reflect.declaration.CtField spoon.reflect.factory.Factory::createField(spoon.reflect.declaration.CtType<?>, spoon.reflect.declaration.CtField)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 15

Name Element
Old none
New method spoon.reflect.declaration.CtInterface spoon.reflect.factory.Factory::createInterface(java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 16

Name Element
Old none
New method spoon.reflect.declaration.CtInterface spoon.reflect.factory.Factory::createInterface(spoon.reflect.declaration.CtPackage, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 17

Name Element
Old none
New method spoon.reflect.declaration.CtInterface spoon.reflect.factory.Factory::createInterface(spoon.reflect.declaration.CtType, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 18

Name Element
Old none
New method spoon.reflect.declaration.CtMethod spoon.reflect.factory.Factory::createMethod(spoon.reflect.declaration.CtClass, java.util.Set, spoon.reflect.reference.CtTypeReference, java.lang.String, java.util.List>, java.util.Set<spoon.reflect.reference.CtTypeReference<? extends java.lang.Throwable>>, spoon.reflect.code.CtBlock)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 19

Name Element
Old none
New method spoon.reflect.declaration.CtMethod spoon.reflect.factory.Factory::createMethod(spoon.reflect.declaration.CtType, java.util.Set, spoon.reflect.reference.CtTypeReference, java.lang.String, java.util.List>, java.util.Set<spoon.reflect.reference.CtTypeReference<? extends java.lang.Throwable>>)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 20

Name Element
Old none
New method spoon.reflect.declaration.CtMethod spoon.reflect.factory.Factory::createMethod(spoon.reflect.declaration.CtType<?>, spoon.reflect.declaration.CtMethod, boolean)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 21

Name Element
Old none
New method spoon.reflect.declaration.CtPackage spoon.reflect.factory.Factory::createPackage(spoon.reflect.declaration.CtPackage, java.lang.String)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 22

Name Element
Old method java.util.ArrayList org.eclipse.jdt.internal.compiler.batch.Main::handleBootclasspath(java.util.ArrayList, java.lang.String) @ spoon.support.compiler.jdt.JDTBatchCompiler
New method java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath> org.eclipse.jdt.internal.compiler.batch.Main::handleBootclasspath(java.util.ArrayList<java.lang.String>, java.lang.String) @ spoon.support.compiler.jdt.JDTBatchCompiler
Code java.method.returnTypeTypeParametersChanged
Description The return type changed from 'java.util.ArrayList' to 'java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath>'.
Breaking binary: non_breaking

Change 23

Name Element
Old method java.util.ArrayList org.eclipse.jdt.internal.compiler.batch.Main::handleClasspath(java.util.ArrayList, java.lang.String) @ spoon.support.compiler.jdt.JDTBatchCompiler
New method java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath> org.eclipse.jdt.internal.compiler.batch.Main::handleClasspath(java.util.ArrayList<java.lang.String>, java.lang.String) @ spoon.support.compiler.jdt.JDTBatchCompiler
Code java.method.returnTypeTypeParametersChanged
Description The return type changed from 'java.util.ArrayList' to 'java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath>'.
Breaking binary: non_breaking

Change 24

Name Element
Old method java.util.ArrayList org.eclipse.jdt.internal.compiler.batch.Main::handleEndorseddirs(java.util.ArrayList) @ spoon.support.compiler.jdt.JDTBatchCompiler
New method java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath> org.eclipse.jdt.internal.compiler.batch.Main::handleEndorseddirs(java.util.ArrayList<java.lang.String>) @ spoon.support.compiler.jdt.JDTBatchCompiler
Code java.method.returnTypeTypeParametersChanged
Description The return type changed from 'java.util.ArrayList' to 'java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath>'.
Breaking binary: non_breaking

Change 25

Name Element
Old method java.util.ArrayList org.eclipse.jdt.internal.compiler.batch.Main::handleExtdirs(java.util.ArrayList) @ spoon.support.compiler.jdt.JDTBatchCompiler
New method java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath> org.eclipse.jdt.internal.compiler.batch.Main::handleExtdirs(java.util.ArrayList<java.lang.String>) @ spoon.support.compiler.jdt.JDTBatchCompiler
Code java.method.returnTypeTypeParametersChanged
Description The return type changed from 'java.util.ArrayList' to 'java.util.ArrayList<org.eclipse.jdt.internal.compiler.batch.FileSystem.Classpath>'.
Breaking binary: non_breaking

Change 26

Name Element
Old method void org.eclipse.jdt.internal.compiler.batch.Main::setPaths(java.util.ArrayList, java.lang.String, java.util.ArrayList, java.util.ArrayList, java.util.ArrayList, java.util.ArrayList, java.lang.String) @ spoon.support.compiler.jdt.JDTBatchCompiler
New method void org.eclipse.jdt.internal.compiler.batch.Main::setPaths(java.util.ArrayList<java.lang.String>, java.lang.String, java.util.ArrayList<java.lang.String>, java.util.ArrayList<java.lang.String>, java.lang.String, java.lang.String, java.util.ArrayList<java.lang.String>, java.util.ArrayList<java.lang.String>, java.lang.String) @ spoon.support.compiler.jdt.JDTBatchCompiler
Code java.method.numberOfParametersChanged
Description The number of parameters of the method have changed.
Breaking binary: breaking

@monperrus monperrus merged commit 3f81ec4 into INRIA:master Oct 27, 2017
@monperrus
Copy link
Collaborator

thanks! will be super useful for client code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants