Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix: the imports should be properly computed after processing #2083

Merged
merged 11 commits into from
Jun 25, 2018
Merged

review: fix: the imports should be properly computed after processing #2083

merged 11 commits into from
Jun 25, 2018

Conversation

surli
Copy link
Collaborator

@surli surli commented Jun 19, 2018 •
edited
Loading

Current import mechanism is the following:

  1. We get existing imports from the source and put them in the compilation unit
  2. When pretty printing, we compute again the imports and add the new ones

We never delete in step 2 an import that has been added in step 1 because it's really tedious.

This was referenced Jun 19, 2018
Closed
Closed
@surli surli changed the title WiP: fix: the imports should be properly computed after processing review: fix: the imports should be properly computed after processing Jun 22, 2018
@surli
Copy link
Collaborator Author

surli commented Jun 22, 2018

This PR is ready to be reviewed, but please wait #2096 and #2090 to be merged and the CI launched again, before merging it.

@surli surli changed the title review: fix: the imports should be properly computed after processing WIP: fix: the imports should be properly computed after processing Jun 22, 2018
@surli surli mentioned this pull request Jun 22, 2018
Closed
@surli surli changed the title WIP: fix: the imports should be properly computed after processing review: fix: the imports should be properly computed after processing Jun 25, 2018
@spoon-bot
Copy link
Collaborator

API changes: 1 (Detected by Revapi)

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180625.075952-168 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT

Method was added to an interface.
Old none
New method ImportScanner#initWithImports(Collection)
Breaking binary: non_breaking

@monperrus monperrus merged commit 0bb8fed into INRIA:master Jun 25, 2018
@surli surli deleted the fix-process-and-imports branch June 25, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surli @spoon-bot @monperrus