fix(CtElementImpl#toString): fix toString for SniperPrinter #3147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recent changes,
CtElement#toString()
calls the default prettyprinter which can be aSniperPrinter
.AFAIU, this fails for two reasons:
toString()
clone the element before printing it, andSniperPrinter
usegetRoleInCompilationUnit()
. ButgetRoleInCompilationUnit()
implement a Scanner that look for the exact element in its parent children. Of course the clone has a parent but is not among the children of its parent.SniperPrinter
require someSourceFragmentContext
to be pushed on a stack to print an arbitrary element that is not aCompilationUnit
. This must be initialized before.This PR implement a POC that solves these two problems. But I am not sure if that's the direction we want to take. (Currently it makes an ugly check in
toString()
's body to check what sort of printer we have, but it could be rewritten to be hidden insideSniperPrinter
.)WDYT?
@monperrus
@pvojtechovsky (if you have time) am I mistaken on the behavior of
SniperPrinter
?