Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct package assumption when there is a star import #3338

Merged
merged 5 commits into from
May 5, 2020
Merged

fix: correct package assumption when there is a star import #3338

merged 5 commits into from
May 5, 2020

Commits on Apr 19, 2020

  1. Add failing test case for type access+star import with no classpath

    @slarse
    slarse committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    59afc62 View commit details
    Browse the repository at this point in the history

  2. Avoid guessing type's package if there is any star import 

    This is too restrictive, and counts e.g. java.util.* as an offending import, even though it's fine
    @slarse
    slarse committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    2a0cdcf View commit details
    Browse the repository at this point in the history

  3. Fix incorrect indentation

    @slarse
    slarse committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    76f2592 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Assert noclasspath mode instead of checking it 

    We should never get here in classpath mode
    @slarse
    slarse committed May 4, 2020
    Configuration menu
    Copy the full SHA
    157fdd1 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Move assertion to start of block

    @slarse
    slarse committed May 5, 2020
    Configuration menu
    Copy the full SHA
    4351bde View commit details
    Browse the repository at this point in the history