test: fix assertions for newer jdks and refactor old test code. #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
changed the title
monperrus
changed the title
|
Thanks a lot @MartinWitt |
Strum355
pushed a commit
to Strum355/spoon
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As i wrote in issue #3547 we have some testcase, which are jdk dependent. Goal of this patch is to fix them all and as always refactor the testcase to reach a higher quality standard. Looking into the older testcases, there is still alot of refactoring work needed unrelated to bugs. I try to create as minimal diffs as possible while still refactoring the code to a newer style.