fix: fix incorrect parent for type reference of a CtParameter #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andrewbwogi for the work on this fix. Could you have a look at the CI failures? |
andrewbwogi
changed the title
andrewbwogi
commented
Nov 20, 2020
Comment on lines
+82
to
+86
| if (parameter.getType() == null) { | ||
| ref.setType(parameter.getType()); | ||
| } else { | ||
| ref.setType(parameter.getType().clone()); | ||
| } |
There was a problem hiding this comment.
This solution works but it hides an implicit difference between ordinary parameters and parameters in lambda expressions. Is it better to create a CtLambdaParameter class?
It would probably be overkill. Do you mean that we don't have a fully backward compatible fix for now? |
|
The fix only expands information in the AST so it should be backwards compatible. |
andrewbwogi
changed the title
|
Great, thanks @andrewbwogi ! In Spoon, we always have a one line contract in natural language for each test: Could you add the contract? Then we merge! |
monperrus
changed the title
|
Thanks @andrewbwogi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3671