test: replace jre matching check with JUnit annotation

[Artamm]

(Close #3682)
Some methods in test cases are replaced with annotations. In VariableTest class the annotation is also added on tests that use methods "since jdk_version".

[monperrus]

Cool!

[Artamm]

I'm facing a problem in TestModule class. In this class are used @Test from junit-vintage, which ignore junit5 annotations (including @DisabledForJreRange). However, if I change import, the test case testSimpleModuleCanBeBuilt fails because instead of 2 modules it gets only 1 (simple_module_with_code is not included).
On the one hand, disabling jre is not important here and can be ignored, but maybe there is a way to fix this problem?

[monperrus]

thanks for the update.

the test case testSimpleModuleCanBeBuilt fails because instead of 2 modules it gets only 1 (simple_module_with_code is not included).

Seems we can simply change this assertion.

[MartinWitt]

Hi,
I`m surprised how well the annotation works :D
LGTM and CI seems green.

[Artamm]

LGTM and CI seems green.

Hello. I think CI is green because now in TestModule is used junit4 @Test annotation, so in the test case there are 2 modules and checks pass (but @DisabledForJreRange is ignored). If replace with junit5 @test, the test case will have 1 module and check will fail, but the annotation will work.
If it's okay, I think that changing the assertion can work (like @monperrus said) . Or removing annotation, since in launcher is set jre version anyway.

[MartinWitt]

Or removing annotation, since in launcher is set jre version anyway.

If the test is green afterwards perfect solution, but changing the assertion is fine for me as well.

If replace with junit5 @test, the test case will have 1 module and check will fail, but the annotation will work.

This seems strange but debugging junit5 is not a nice task. I wouldn't prefer not to look into it.

[monperrus]

Thanks a lot @Artamm LGTM

@MartinWitt OK to merge?

[MartinWitt]

Yes! Works perfect, nice work @Artamm !

[monperrus]

Very nice contribution @Artamm !