Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup GitHub Actions workflow for continuous integration #3723

Merged
merged 20 commits into from
Dec 9, 2020

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Dec 8, 2020

#3600

Adds GitHub workflows for tests. The following is adapted from the Travis jobs:

  • mvn test with JDK 1.8, 11 and 15
  • Coverage uploading to coveralls
  • The extra checks in travis-extras.sh, except for the external CI stuff

The following is not adapted from the Travis jobs:

  • Running of the external CI jobs in https://github.com/SpoonLabs/spoon-ci-external, as they depend on Travis
    • This is simply skipped in travis-extra.sh as the environment variables don't match for the final if-check
  • The chore/travis/travis-master.sh script, as it depends on Travis
    • This script isn't executed at all, it appears to post data to spoon-ci-external.

In regards to #3691, it would probably be simple to add a Windows build to the workflow as well.

I have not removed the Travis stuff, I'm assuming that we'll use GH Actions as a backup for when Travis becomes unavailable.

@slarse slarse changed the title wip: chore: Setup GitHub actions workflow for tests review: chore: Setup GitHub actions workflow for tests Dec 8, 2020
@slarse
Copy link
Collaborator Author

slarse commented Dec 8, 2020

Ping @monperrus

Took me a while to get coverage uploading to work, but now all of the most important tests and checks are running on GH Actions.

@slarse
Copy link
Collaborator Author

slarse commented Dec 8, 2020

I realized something: the new gha-extras.sh is essentially a copy of travis-extras.sh, with the final part of it removed. I'm gonna try running with travis-extras.sh instead, to reduce duplication. It should work as-is.

@slarse slarse changed the title review: chore: Setup GitHub actions workflow for tests wip: chore: Setup GitHub actions workflow for tests Dec 8, 2020
It will work fine as the final if-check is false anyway
@slarse
Copy link
Collaborator Author

slarse commented Dec 8, 2020

Sorry, unping Martin, I had missed some things.

@slarse slarse changed the title wip: chore: Setup GitHub actions workflow for tests review: chore: Setup GitHub actions workflow for tests Dec 8, 2020
@slarse
Copy link
Collaborator Author

slarse commented Dec 8, 2020

@monperrus Okay, now it's done!

@monperrus
Copy link
Collaborator

Thanks a lot LGTM.

@monperrus monperrus changed the title review: chore: Setup GitHub actions workflow for tests chore: setup GitHub Actions workflow for continuous integration Dec 9, 2020
@monperrus monperrus merged commit aa7f0a4 into INRIA:master Dec 9, 2020
@monperrus
Copy link
Collaborator

Thanks a lot @slarse now we have CI again!

@slarse
Copy link
Collaborator Author

slarse commented Dec 9, 2020

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants