Missing CtTypeReference for instanceof expressions when querying. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @revaultch and this PR should fixed this issue #349 so that's cool! :) |
| launcher.run(); | ||
| final CtClass<?> aClassX = (CtClass<?>) launcher.getFactory().Type().get("spoon.test.refactoring.testclasses.AClassX"); | ||
|
|
||
| final CtBinaryOperator<?> instanceofInvocation = aClassX.getElements(new AbstractFilter<CtBinaryOperator<?>>(CtBinaryOperator.class) { |
There was a problem hiding this comment.
There is a better way to do that: use new TypeFilter<CtBinaryOperator<?>>(CtBinaryOperator.class).
formatting fixed
|
I imported SpoonFormatterPrefs.xml in Eclipse, but the resulting formatting doesn't seem to correspond to what's in the repo. Can you update said file or give instructions on the formatting? |
|
Thanks for the report, I created an issue for that: #393 |
monperrus
added a commit
that referenced
this pull request
Oct 25, 2015
|
Thanks a lot @revaultch for this first contribution to Spoon! You can propose a PR on the README/pom.cml to add your name in the list of contributors. Closes #349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rewriting a type instanceof expressions are not updated with the new type.