Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix violation of Sonar rule 2097 #3972

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented May 31, 2021

PULL REQUEST TITLE:
Hi,

This PR fixes 1 violation of Sonar Rule 2097: '"equals(Object obj)" should test argument type'.

The patch was generated automatically with the tool Sorald. For details on the fix applied here, please see Sorald's documentation on rule 2097.

The violation can be seen in Spoon's SonarQube dashboard.

@slarse slarse changed the title fix: Fix violation of Sonar rule 2097 review: fix: Fix violation of Sonar rule 2097 May 31, 2021
@monperrus monperrus changed the title review: fix: Fix violation of Sonar rule 2097 fix: Fix violation of Sonar rule 2097 Jun 1, 2021
@monperrus monperrus merged commit 827161b into INRIA:master Jun 1, 2021
@monperrus
Copy link
Collaborator

oh nice! note that the PR title contains PULL REQUEST TITLE:. A templating issue?

@slarse
Copy link
Collaborator Author

slarse commented Jun 1, 2021

oh nice! note that the PR title contains PULL REQUEST TITLE:. A templating issue?

A copy/paste issue :)

@slarse slarse deleted the fix-2097-violation branch June 1, 2021 06:18
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants