Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ZipFolder): fix zip slip issue #4199

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

MartinWitt
Copy link
Collaborator

This PR fixes an issue with zip slips

@lgtm-com
Copy link

lgtm-com bot commented Oct 3, 2021

This pull request fixes 1 alert when merging b43bbf0 into d9bcb11 - view on LGTM.com

fixed alerts:

  • 1 for Arbitrary file write during archive extraction ("Zip Slip")

@MartinWitt MartinWitt changed the title refactor(ZipFolder): fix zip slip issue review: refactor(ZipFolder): fix zip slip issue Oct 3, 2021
@monperrus
Copy link
Collaborator

LGTM, will merge.

FYI, the corresponding automated fix by Whitespace Cure: https://cure.whitesource.io/#/report/b875ed921e9511ecb5c90242ac110003/cwe/22/nodeId/1/runId/25

@monperrus monperrus changed the title review: refactor(ZipFolder): fix zip slip issue refactor(ZipFolder): fix zip slip issue Oct 5, 2021
@monperrus monperrus merged commit 71f08a6 into INRIA:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants