Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Migrate ImportAndExtendWithPackageNameTest to JUnit5 #4238

Merged
merged 1 commit into from
Oct 19, 2021
Merged

test: Migrate ImportAndExtendWithPackageNameTest to JUnit5 #4238

merged 1 commit into from
Oct 19, 2021

Conversation

spencerwi
Copy link
Contributor

@spencerwi spencerwi commented Oct 19, 2021 •
edited by slarse
Loading

#3919

One last PR to hit the one last test at the top level of this package. :)

This one's pretty trivial, but for completeness I figured it was worth chipping in.

slarse
slarse approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spencerwi, lgtm!

@slarse slarse merged commit e6c9fc9 into INRIA:master Oct 19, 2021
@slarse
Copy link
Collaborator

slarse commented Oct 19, 2021

Word to other integrators, I fast-tracked this as it's so tiny and can't in my wildest dreams imagine anyone disagreeing here :)

@monperrus monperrus mentioned this pull request Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarse slarse slarse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerwi @slarse