fix: remove annotation from the pretty-printed string if it is deleted from the model

[algomaster99]

Fixes #4218

I am still looking for a fix for this, but I think the problem could be with the changeCollector. The size of the map elementToChangeRole is 0, which is unusual as we have altered the type by deleting the annotation attached to it. Thus, I am concluding that it fails to listen for deletion of annotation in the model build for the resource file in this PR.

EDIT:

onChange is not being called when I delete an annotation, however, it is called when I delete an instance of CtField inside a CtType. This should confirm that what I am saying above is right.

[monperrus]

onChange is not being called when I delete an annotation, however, it is called when I delete an instance of CtField inside a CtType. This should confirm that what I am saying above is right.

seems you have the core idea of the fix :)

[algomaster99]

@monperrus, and here comes this fix!

When all annotations are deleted, this.annotations is set to emptyList, but we also need to register this change in the environment. The patch does exactly that.

Note that I also removed the the listener just after this.annotations.clear because we shall be registering addition in the loop which follows.

[algomaster99]

@monperrus @slarse @nharrand need your reviews. The tests have passed.

[monperrus]

nice, LGTM. thanks @algomaster99

there are many more test cases in #4018, does this fix make them all pass?

[algomaster99]

@monperrus I think I linked the wrong issue. 🤦‍♂️ Let me find the correct one.

[algomaster99]

@monperrus I found it. It was #4218 instead of 4018.

Let me reword the first commit message before we merge. I am doing that just for the logs even though it won't matter because we shall squash and merge.

[algomaster99]

@monperrus Some certifcate has expired which is making tests fail.

Run actions/setup-java@8db439b6b47e5e12312bf036760bbaa6893481ac
  with:
    java-version: 16
    distribution: temurin
    java-package: jdk
    architecture: x64
    check-latest: false
    server-id: github
    server-username: GITHUB_ACTOR
    server-password: GITHUB_TOKEN
    overwrite-settings: true
    job-status: success
  env:
    JAVA_DISTRIBUTION: temurin
    MAVEN_OPTS: -Djava.src.version=16 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
Trying to resolve the latest version from remote
Error: certificate has expired

Do you know what certificate are they talking about? Failing step.