Fix bug related to "insertBefore()" and "getSignature()"

[maxcleme]

There is the same bug on insertAfter, but i didn't succeed to fix it.

[monperrus]

oops? indentation with tabs? (this is the cause of travis' failure)

[maxcleme]

Hi,

I just tried to use the formatter included with the spoon' repository ( SpoonFormatterPrefs.xml ), however when I apply it to the project, 458 files are modified. Do you really use this formatter ?

[GerardPaligot]

Nope: #393

[tdurieux]

Too clarify this fix:
The error was in this line int indexOfTargetElement = block.getStatements().indexOf(target); because indexOf uses the equality between two objects but in this case we are looking for the reference equality (that was the case before 6703c2e#diff-0e647d5fcf8e2eea99bd6087436a08baL190).
The bug is probably also present in other locations of this class.

[monperrus]

that was the case before
6703c2e#diff-0e647d5fcf8e2eea99bd6087436a08baL190
6703c2e#diff-0e647d5fcf8e2eea99bd6087436a08baL190
fun! a test was clearly missing :-)

[tdurieux]

I fixed the insertEnd and insertAfter in this branch https://github.com/tdurieux/spoon/tree/fix-insert

[monperrus]

after discussion with @maxcleme , he lets us resolve the formatting (grrr #393) and add the missing case.
@GerardPaligot , do you handle this?

[GerardPaligot]

@tdurieux already did it this morning: https://github.com/maxcleme/spoon/pull/1

[monperrus]

could you close this PR and check and accept the other one?

[GerardPaligot]

The PR of @tdurieux isn't on the spoon project. It is a PR on this PR. @maxcleme must accept it and this PR will be automatically updated.