refactor(FactoryImpl): use ThreadLocal.initialValue #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following has changed in the code: ThreadLocal with initialValue new spoon.reflect.factory.FactoryImpl.Dedup() was replaced by ThreadLocal.withInitialValue(java.lang.ThreadLocal.withInitial(() -> new spoon.reflect.factory.FactoryImpl.Dedup())) ThreadLocal with initialValue new spoon.reflect.factory.FactoryImpl.Dedup() was replaced by ThreadLocal.withInitialValue(java.lang.ThreadLocal.withInitial(() -> new spoon.reflect.factory.FactoryImpl.Dedup())) Replaced lambda () -> new spoon.reflect.factory.FactoryImpl.Dedup() with executable ref spoon.reflect.factory.FactoryImpl.Dedup::new Replaced lambda () -> new spoon.reflect.factory.FactoryImpl.Dedup() with executable ref spoon.reflect.factory.FactoryImpl.Dedup::new
|
This clearly shows that there is some overlap between laughing-train and Sorald. This fix would be 100% in the scope of Sorald :) To be discussed at our coming meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
The following bad smells are refactored:
LambdaInsteadOfExecutableReference
Lambda is used instead of executable reference
ThreadLocalWithInitialValue
ThreadLocalwith initialValue override shall be replaced byThreadLocal.withInitialValueThe following has changed in the code:
ThreadLocalWithInitialValue
ThreadLocalwith initialValuenew spoon.reflect.factory.FactoryImpl.Dedup()was replaced byThreadLocal.withInitialValue(java.lang.ThreadLocal.withInitial(() -> new spoon.reflect.factory.FactoryImpl.Dedup()))ThreadLocalwith initialValuenew spoon.reflect.factory.FactoryImpl.Dedup()was replaced byThreadLocal.withInitialValue(java.lang.ThreadLocal.withInitial(() -> new spoon.reflect.factory.FactoryImpl.Dedup()))LambdaInsteadOfExecutableReference
() -> new spoon.reflect.factory.FactoryImpl.Dedup()with executable refspoon.reflect.factory.FactoryImpl.Dedup::new() -> new spoon.reflect.factory.FactoryImpl.Dedup()with executable refspoon.reflect.factory.FactoryImpl.Dedup::newThe changes in the import statements is simple alphabetic order. Seems strange to me that we don't enforce a real order.