Use CtTypeAccess for CtFieldRead of .class and instanceof #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,4 +25,7 @@ | |||
| * type in the expression. | |||
| */ | |||
| public interface CtTypeAccess<T> extends CtExpression<T> { | |||
| boolean isClassType(); | |||
There was a problem hiding this comment.
to be discussed. I'm not sure this have to explicit in the metamodel, it may be inferred from the context where it is used (e.g. with the parent)
There was a problem hiding this comment.
I'm agree that should be discussed. Me, I prefer come back to CtFieldRead.
| CtBinaryOperator<?> op = (CtBinaryOperator<?>) ass.getDefaultExpression(); | ||
| assertEquals("Class", op.getLeftHandOperand().getType().getSimpleName()); | ||
| assertFalse(op.getLeftHandOperand().getType().isPrimitive()); | ||
| assertEquals("short", op.getRightHandOperand().getType().getSimpleName()); |
There was a problem hiding this comment.
Should return Class and op.getLeftHandOperand().getTarget().getSimpleName() return short.
GerardPaligot
changed the title
CtLiteral for CtTypeAccess
|
@monperrus PR ok for me. If ok for you, you can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.