fix: Maintain insertion of types in a package #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
commented
Aug 8, 2022
|
|
||
| // This can not be a "Map" as this class is Serializable and therefore Sorald wants this field | ||
| // to be serializable as well (Rule 1948). | ||
| // It doesn't seem smart enough to realize it is final and only assigned to a Serializable Map | ||
| // in the constructor. | ||
| private final ConcurrentSkipListMap<String, T> map; | ||
| private final ConcurrentHashMap<String, InsertOrderWrapper<T>> map; |
There was a problem hiding this comment.
The hash map generally performs better. The ordering of the skip list map wasn't what we wanted.
I-Al-Istannen
approved these changes
Aug 8, 2022
src/test/java/spoon/support/util/internal/ElementNameMapTest.java
Outdated
Show resolved
Hide resolved
slarse
changed the title
MartinWitt
changed the title
|
Thanks, @slarse |
slarse
deleted the
issue/4827-maintain-insertion-order-in-eleementnamemap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4827
Adjusts the
ElementNameMapto maintain an insertion order of it's entries, which in turn allows us to maintain insertion order of contained types. This will result in a performance hit onentrySet()due to the sorting, but I don't think it should be all that bad.If we want to improve performance further we'll need to implement a concurrent version of a
LinkedHashMap, or something similar.@I-Al-Istannen Thoughts?