review: fix: getTypeDeclaration() on nested record type #5015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com> Co-authored-by: Martin Wittlinger <wittlinger.martin@gmail.com>
I-Al-Istannen
force-pushed
the
fix/get-type-declaration-nested-record
branch
from
42ae027 to
b4eddca
Compare
MartinWitt
previously approved these changes
Dec 20, 2022
|
@I-Al-Istannen @SirYwell could both of you also mark this PR for approval (after a review) and we simply merge it? |
|
Github won't let me approve it as I am the author. But consider this my approval :P |
SirYwell
previously approved these changes
Dec 21, 2022
|
@monperrus could you have a brief look and merge this PR? As all of us three are (co)authors. |
slarse
suggested changes
Dec 25, 2022
src/main/java/spoon/support/reflect/declaration/CtTypeImpl.java
Outdated
Show resolved
Hide resolved
I-Al-Istannen
dismissed stale reviews from SirYwell and MartinWitt
via
6024979
slarse
approved these changes
Dec 26, 2022
|
thanks all! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested visitor did not consider records as it was written before their existence.
We might want to find a better upgrade story for such cases.