fix: isOverriding check with generic throws clause #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
approved these changes
Mar 5, 2023
MartinWitt
changed the title
|
Thanks @I-Al-Istannen |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small oversight where the cloned throws clause was adapted instead of the original. As the cloned method does not have a parent, lookup of the enclosing type failed and an exception was thrown.
It would likely also be possible to use a method context for the adaption and then try to adapt formal type parameters to the submethod, but that does not make a difference for the overriding check as far as I can see. It would complicate the implementation and be slower though, so I did not do this here.
Closes #5115.