review: feat: configurable encoding of processed source code #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
…43-processed-code-encoding
MartinWitt
requested changes
Jul 18, 2023
| @@ -39,6 +39,8 @@ public class JavaOutputProcessor extends AbstractProcessor<CtNamedElement> imple | |||
|
|
|||
| List<File> printedFiles = new ArrayList<>(); | |||
|
|
|||
| Charset charset = Charset.defaultCharset(); | |||
There was a problem hiding this comment.
Can you make this field private? The other fields are public but that seems like a design flaw.
There was a problem hiding this comment.
Sure, I changed it.
tenax66
changed the title
MartinWitt
approved these changes
Jul 20, 2023
|
Thanks @tenax66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #5343.
With this commit,
JavaOutputProcessornow usesPrintStream(File file, Charset charset)instead ofPrintStream(File file).By default,
Charset.defaultCharset()is assigned tocharset. So the default behavior remains the same.