Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: test: reproduce Sorald's test failure #5355

Closed
wants to merge 15 commits into from

Conversation

algomaster99
Copy link
Contributor

@algomaster99 algomaster99 commented Jul 19, 2023

https://github.com/ASSERT-KTH/sorald's CI has been failing for some time, and one of the reason is that the classpath is not resolved in one of our tests - https://github.com/ASSERT-KTH/sorald/blob/master/sorald/src/test/java/sorald/ClasspathModeTest.java#L22.

The test used to pass two months ago (ASSERT-KTH/sorald@97758ed), and with no new commits to the repository, it now fails. Something may have changed with the GitHub action runner. Please note that the test still passes on local, and hence it is making debugging tougher.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jul 19, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@algomaster99
Copy link
Contributor Author

@MartinWitt @I-Al-Istannen can you please have a look at it when you have time?

@I-Al-Istannen
Copy link
Collaborator

I can't reproduce this locally, any tips before I take a close look? :)

@algomaster99
Copy link
Contributor Author

I am unable to produce it locally, as well. The test in this patch passes on my system. It is just the CI which is failing and I don't understand why.

@I-Al-Istannen
Copy link
Collaborator

Sad times. Looks like I will need to invest some more time then…

@algomaster99
Copy link
Contributor Author

Thanks! I will also try looking into it during the week :)

@MartinWitt
Copy link
Collaborator

Hey,

you have some maven http blocker in the log, see https://github.com/ASSERT-KTH/sorald/actions/runs/5602147660/job/15176115010?pr=1045#step:11:34. There seems something wrong, you normally should have this error.

@I-Al-Istannen I-Al-Istannen force-pushed the sorald-failure branch 2 times, most recently from 77c3394 to 60e4243 Compare July 23, 2023 21:26
@I-Al-Istannen
Copy link
Collaborator

Alright, this now fails consistently for me. I think the early failure in CI was because CI uses a newer maven version which changed the http defaults around?

But yea, the reasons seems to be that the inria repo (http://maven.inria.fr/artifactory/spoon-public-snapshot/
) uses http and is referenced by the ancient spoon-core 8.0.0 dependency in gumtree. See

Error:  Failed to execute goal on project sorald.test.project: Could not
resolve dependencies for project
sorald.test:sorald.test.project:jar:1.0-SNAPSHOT: Failed to collect
dependencies at fr.inria.gforge.spoon.labs:gumtree-spoon-ast-diff:jar:1.24 ->
fr.inria.gforge.spoon:spoon-core:jar:8.0.0 ->
org.eclipse.jdt:org.eclipse.jdt.core:jar:3.16.0 ->
org.eclipse.platform:org.eclipse.core.resources:jar:3.12.0 ->
org.eclipse.platform:org.eclipse.core.expressions:jar:3.5.100 ->
org.eclipse.platform:org.eclipse.core.runtime:jar:3.12.0 ->
org.eclipse.platform:org.eclipse.equinox.preferences:jar:3.10.1 ->
org.osgi:org.osgi.service.prefs:jar:1.1.1-SNAPSHOT: Failed to read artifact
descriptor for org.osgi:org.osgi.service.prefs:jar:1.1.1-SNAPSHOT: Could not
transfer artifact org.osgi:org.osgi.service.prefs:pom:1.1.1-SNAPSHOT from/to
maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories:
[gforge.inria.fr-release
(http://maven.inria.fr/artifactory/spoon-public-snapshot/, default,
releases+snapshots), maven.inria.fr-snapshot
(http://maven.inria.fr/artifactory/spoon-public-snapshot, default,
releases+snapshots)] -> [Help 1]

at https://github.com/INRIA/spoon/actions/runs/5638723373/job/15273145423?pr=5355#step:10:858

@algomaster99
Copy link
Contributor Author

algomaster99 commented Jul 24, 2023

Ah okay. I will update the dependency version in the test resource to the latest version then.

EDIT: It seems to have fixed it. Thank you!

@algomaster99 algomaster99 deleted the sorald-failure branch July 24, 2023 09:35
@I-Al-Istannen
Copy link
Collaborator

Very nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants