-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question: test: reproduce Sorald's test failure #5355
Conversation
This reverts commit 68149e0.
…NRIA#5353)" This reverts commit a4ad69f.
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
@MartinWitt @I-Al-Istannen can you please have a look at it when you have time? |
I can't reproduce this locally, any tips before I take a close look? :) |
I am unable to produce it locally, as well. The test in this patch passes on my system. It is just the CI which is failing and I don't understand why. |
Sad times. Looks like I will need to invest some more time then… |
Thanks! I will also try looking into it during the week :) |
Hey, you have some maven http blocker in the log, see https://github.com/ASSERT-KTH/sorald/actions/runs/5602147660/job/15176115010?pr=1045#step:11:34. There seems something wrong, you normally should have this error. |
77c3394
to
60e4243
Compare
60e4243
to
d95b506
Compare
Alright, this now fails consistently for me. I think the early failure in CI was because CI uses a newer maven version which changed the http defaults around? But yea, the reasons seems to be that the inria repo (http://maven.inria.fr/artifactory/spoon-public-snapshot/
|
Ah okay. I will update the dependency version in the test resource to the latest version then. EDIT: It seems to have fixed it. Thank you! |
Very nice :) |
https://github.com/ASSERT-KTH/sorald's CI has been failing for some time, and one of the reason is that the classpath is not resolved in one of our tests - https://github.com/ASSERT-KTH/sorald/blob/master/sorald/src/test/java/sorald/ClasspathModeTest.java#L22.
The test used to pass two months ago (ASSERT-KTH/sorald@97758ed), and with no new commits to the repository, it now fails. Something may have changed with the GitHub action runner. Please note that the test still passes on local, and hence it is making debugging tougher.