Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix: Filter resources to replace version placeholder #5401

Merged
merged 2 commits into from
Aug 28, 2023
Merged

review: fix: Filter resources to replace version placeholder #5401

merged 2 commits into from
Aug 28, 2023

Conversation

I-Al-Istannen
Copy link
Collaborator

Closes #4249

@I-Al-Istannen I-Al-Istannen self-assigned this Aug 27, 2023
@MartinWitt
Copy link
Collaborator

How about this small formatting change? Otherwise LGTM.

@I-Al-Istannen
Copy link
Collaborator Author

I-Al-Istannen commented Aug 28, 2023 •
edited
Loading

I added that consciously to separate plugins and resources :( But sure :P

monperrus
monperrus approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@monperrus monperrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monperrus monperrus merged commit e623d6f into INRIA:master Aug 28, 2023
11 checks passed
@monperrus
Copy link
Collaborator

thanks @I-Al-Istannen

@I-Al-Istannen I-Al-Istannen deleted the fix/bundled-spoon-version branch August 28, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monperrus monperrus monperrus approved these changes

@MartinWitt MartinWitt Awaiting requested review from MartinWitt

Assignees

@I-Al-Istannen I-Al-Istannen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

${spoon.version} displayed for version 3.5
3 participants
@I-Al-Istannen @MartinWitt @monperrus