-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation adding and editing #5490
Closed
Closed
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ead4fc1
Update PrinterHelper.java
TheMarvelFan 4ea6c8c
Added documentation for methods
TheMarvelFan 2d5b85a
Merge branch 'master' into master
TheMarvelFan 1c9aec1
Merge branch 'master' into master
TheMarvelFan 4cd4a7c
Merge branch 'master' into master
TheMarvelFan 06e733a
Merge branch 'master' into master
TheMarvelFan 606019b
Added new documentation and corrected old one based on the reviews
TheMarvelFan a6ae2c5
Merge branch 'master' into master
TheMarvelFan 68163f7
Kept documentation for only three methods.
TheMarvelFan a2811b5
Modified the javadocs as requested.
TheMarvelFan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,11 @@ public class CacheBasedConflictFinder { | |
typeRef = type.getReference(); | ||
} | ||
|
||
/** returns true if the given name is a field name */ | ||
/** | ||
* Checks if a field with the given name conflicts with fields in the type's scope. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Explain what a conflict is. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will add the suggested changes. |
||
* @param name The name of the field to check for conflicts. | ||
* @return true if a field with the same name exists in the type's scope, false otherwise. | ||
*/ | ||
public boolean hasFieldConflict(String name) { | ||
if (cachedFieldNames == null) { | ||
Collection<CtFieldReference<?>> allFields = type.getAllFields(); | ||
|
@@ -40,7 +44,11 @@ public boolean hasFieldConflict(String name) { | |
return cachedFieldNames.contains(name); | ||
} | ||
|
||
/** returns true if the given name is a nested type name */ | ||
/** | ||
* Checks if a nested type with the given name conflicts with nested types in the type's scope. | ||
* @param name The name of the nested type to check for conflicts. | ||
* @return true if a nested type with the same name exists in the type's scope, false otherwise. | ||
*/ | ||
public boolean hasNestedTypeConflict(String name) { | ||
if (cachedNestedTypeNames == null) { | ||
Collection<CtType<?>> allTypes = type.getNestedTypes(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont get where this method enforces references sharing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not exactly enforce sharing references, but allows sharing reference across the Abstract Syntax Tree. I will correct this.