Fix bugs in ImportScannerImpl #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case? |
|
Ok, will do. .. While doing this I found another bug, in the meantime, could you please explain why you added |
|
|
leventov
force-pushed
the
visit_executable_reference_bug
branch
from
113e91d
to
e39c74a
Compare
leventov
changed the title
|
@GerardPaligot I don't understand your explaination, please check this PR again, I think the test case shows why this call shouldn't be there. |
leventov
force-pushed
the
visit_executable_reference_bug
branch
2 times, most recently
from
a0ab6b2
to
52e6489
Compare
| && reference.getDeclaringType().getDeclaringType() == null) { | ||
| addImport(reference.getDeclaringType()); | ||
| // constructor call | ||
| if (reference.getSimpleName().equals("<init>")) { |
leventov
force-pushed
the
visit_executable_reference_bug
branch
from
52e6489
to
f999022
Compare
leventov
force-pushed
the
visit_executable_reference_bug
branch
from
f999022
to
538a705
Compare
|
Ok I finally made this PR to pass all tests, please review again |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.