Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency org.eclipse.jdt:org.eclipse.jdt.core to v3.39.0 #5977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.eclipse.jdt:org.eclipse.jdt.core (source) 3.38.0 -> 3.39.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@SirYwell
Copy link
Collaborator

It looks like JDT dropped support for targeting Java 1.7. So the minimum compliance level must be 8 now.

@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 3 times, most recently from 2e8d1a4 to 3ff11be Compare October 8, 2024 09:07
@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 9 times, most recently from 72dcbaa to d340d1d Compare October 8, 2024 13:37
@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 15 times, most recently from 0478fb2 to 0805859 Compare October 9, 2024 16:52
@I-Al-Istannen
Copy link
Collaborator

public class Action<Request extends BroadcastRequest<Request>, ShardRequest> {
    private final Request request;
    protected void performOperation(final int shardIndex) {
        ShardRequest shardRequest = newShardRequest(request);
        shardRequest.setParentTask(foobar);
    }
}

This is MWE for the failing stackoverflow test. The new version of JDT does not have a variable binding for the setParentTask method call, as it does not seem to find the definition of the local variable.
Prerequisites:

  • Request is a recursive generic
  • request is passed to newShardRequest
  • The input of setParentTask is an undefined variable (otherwise the declaring type resolves to null even in older JDT versions)

I am not sure if this can reasonably be construed a JDT bug. There is basically nothing valid left in the code, though the connection to the variable feels quite easy to make…

@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 8 times, most recently from 00d63f3 to ef6e2a4 Compare October 15, 2024 15:07
@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch from ef6e2a4 to c57c7dd Compare October 15, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants