Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CtImplicitTypeRef and CtImplicitArrayTypeRef #667

Merged
merged 2 commits into from
May 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/main/java/spoon/reflect/factory/InternalFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
package spoon.reflect.factory;

import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;

/**
* This interface defines the creation methods for internal nodes of the
Expand All @@ -30,14 +28,4 @@ public interface InternalFactory {
* Creates a circular type reference.
*/
CtCircularTypeReference createCircularTypeReference();

/**
* Creates a inference type reference.
*/
<T> CtImplicitTypeReference<T> createImplicitTypeReference();

/**
* Creates an implicit array type reference.
*/
<T> CtImplicitArrayTypeReference<T> createImplicitArrayTypeReference();
}

This file was deleted.

38 changes: 0 additions & 38 deletions src/main/java/spoon/reflect/internal/CtImplicitTypeReference.java

This file was deleted.

12 changes: 0 additions & 12 deletions src/main/java/spoon/reflect/visitor/CtAbstractVisitor.java
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@
import spoon.reflect.declaration.CtPackage;
import spoon.reflect.declaration.CtParameter;
import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.reflect.reference.CtArrayTypeReference;
import spoon.reflect.reference.CtCatchVariableReference;
import spoon.reflect.reference.CtExecutableReference;
Expand Down Expand Up @@ -138,11 +136,6 @@ public <T> void visitCtArrayTypeReference(CtArrayTypeReference<T> reference) {

}

@Override
public <T> void visitCtImplicitArrayTypeReference(CtImplicitArrayTypeReference<T> reference) {

}

@Override
public <T> void visitCtAssert(CtAssert<T> asserted) {

Expand Down Expand Up @@ -387,11 +380,6 @@ public void visitCtCircularTypeReference(CtCircularTypeReference reference) {

}

@Override
public <T> void visitCtImplicitTypeReference(CtImplicitTypeReference<T> reference) {

}

@Override
public <T> void visitCtTypeAccess(CtTypeAccess<T> typeAccess) {

Expand Down
12 changes: 0 additions & 12 deletions src/main/java/spoon/reflect/visitor/CtInheritanceScanner.java
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@
import spoon.reflect.declaration.CtTypedElement;
import spoon.reflect.declaration.CtVariable;
import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.reflect.reference.CtActualTypeContainer;
import spoon.reflect.reference.CtArrayTypeReference;
import spoon.reflect.reference.CtCatchVariableReference;
Expand Down Expand Up @@ -418,11 +416,6 @@ public <T> void visitCtArrayTypeReference(CtArrayTypeReference<T> e) {
visitCtTypeReference(e);
}

@Override
public <T> void visitCtImplicitArrayTypeReference(CtImplicitArrayTypeReference<T> reference) {
visitCtArrayTypeReference(reference);
}

public <T> void visitCtAssert(CtAssert<T> e) {
scanCtStatement(e);
scanCtCodeElement(e);
Expand Down Expand Up @@ -813,11 +806,6 @@ public void visitCtCircularTypeReference(CtCircularTypeReference e) {
visitCtTypeParameterReference(e);
}

@Override
public <T> void visitCtImplicitTypeReference(CtImplicitTypeReference<T> reference) {
visitCtTypeReference(reference);
}

@Override
public <T> void visitCtTypeAccess(CtTypeAccess<T> e) {
scanCtExpression(e);
Expand Down
12 changes: 0 additions & 12 deletions src/main/java/spoon/reflect/visitor/CtScanner.java
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@
import spoon.reflect.declaration.CtPackage;
import spoon.reflect.declaration.CtParameter;
import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.reflect.reference.CtArrayTypeReference;
import spoon.reflect.reference.CtCatchVariableReference;
import spoon.reflect.reference.CtExecutableReference;
Expand Down Expand Up @@ -243,11 +241,6 @@ public <T> void visitCtArrayTypeReference(final CtArrayTypeReference<T> referenc
exit(reference);
}

@Override
public <T> void visitCtImplicitArrayTypeReference(final CtImplicitArrayTypeReference<T> reference) {
visitCtArrayTypeReference(reference);
}

public <T> void visitCtAssert(final CtAssert<T> asserted) {
enter(asserted);
scan(asserted.getAnnotations());
Expand Down Expand Up @@ -744,11 +737,6 @@ public void visitCtCircularTypeReference(final CtCircularTypeReference reference
exit(reference);
}

@Override
public <T> void visitCtImplicitTypeReference(final CtImplicitTypeReference<T> reference) {
visitCtTypeReference(reference);
}

@Override
public <T> void visitCtTypeAccess(final CtTypeAccess<T> typeAccess) {
enter(typeAccess);
Expand Down
12 changes: 0 additions & 12 deletions src/main/java/spoon/reflect/visitor/CtVisitor.java
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@
import spoon.reflect.declaration.CtPackage;
import spoon.reflect.declaration.CtParameter;
import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.reflect.reference.CtArrayTypeReference;
import spoon.reflect.reference.CtCatchVariableReference;
import spoon.reflect.reference.CtExecutableReference;
Expand Down Expand Up @@ -138,11 +136,6 @@ public interface CtVisitor {
*/
<T> void visitCtArrayTypeReference(CtArrayTypeReference<T> reference);

/**
* Visits a reference to an implicit array type.
*/
<T> void visitCtImplicitArrayTypeReference(CtImplicitArrayTypeReference<T> reference);

/**
* Visits an assert.
*/
Expand Down Expand Up @@ -400,11 +393,6 @@ <T, A extends T> void visitCtOperatorAssignment(
*/
void visitCtCircularTypeReference(CtCircularTypeReference reference);

/**
* Visits a reference to an implicit type.
*/
<T> void visitCtImplicitTypeReference(CtImplicitTypeReference<T> reference);

/**
* Visits a type access.
*/
Expand Down
23 changes: 10 additions & 13 deletions src/main/java/spoon/reflect/visitor/DefaultJavaPrettyPrinter.java
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@
import spoon.reflect.declaration.ParentNotInitializedException;
import spoon.reflect.factory.Factory;
import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.reflect.reference.CtActualTypeContainer;
import spoon.reflect.reference.CtArrayTypeReference;
import spoon.reflect.reference.CtCatchVariableReference;
Expand Down Expand Up @@ -631,17 +629,15 @@ public <T, E extends CtExpression<?>> void printCtArrayAccess(CtArrayAccess<T, E
}

public <T> void visitCtArrayTypeReference(CtArrayTypeReference<T> reference) {
if (reference.isImplicit()) {
return;
}
scan(reference.getComponentType());
if (!context.skipArray) {
write("[]");
}
}

@Override
public <T> void visitCtImplicitArrayTypeReference(CtImplicitArrayTypeReference<T> reference) {
// The array type is implicit, we don't print it!
}

public <T> void visitCtAssert(CtAssert<T> asserted) {
enterCtStatement(asserted);
write("assert ");
Expand Down Expand Up @@ -2006,6 +2002,9 @@ public void visitCtTryWithResource(CtTryWithResource tryWithResource) {
}

public void visitCtTypeParameterReference(CtTypeParameterReference ref) {
if (ref.isImplicit()) {
return;
}
writeAnnotations(ref);
if (importsContext.isImported(ref)) {
write(ref.getSimpleName());
Expand Down Expand Up @@ -2040,11 +2039,6 @@ public void visitCtCircularTypeReference(CtCircularTypeReference reference) {
visitCtTypeReference(reference);
}

@Override
public <T> void visitCtImplicitTypeReference(CtImplicitTypeReference<T> reference) {
// The type is implicit, we don't print it!
}

@Override
public <T> void visitCtTypeAccess(CtTypeAccess<T> typeAccess) {
enterCtExpression(typeAccess);
Expand All @@ -2057,6 +2051,9 @@ public void visitCtTypeReferenceWithoutGenerics(CtTypeReference<?> ref) {
}

private void visitCtTypeReference(CtTypeReference<?> ref, boolean withGenerics) {
if (ref.isImplicit()) {
return;
}
if (ref.isPrimitive()) {
writeAnnotations(ref);
write(ref.getSimpleName());
Expand Down Expand Up @@ -2247,7 +2244,7 @@ public DefaultJavaPrettyPrinter writeActualTypeArguments(CtActualTypeContainer c
write("<");
boolean isImplicitTypeReference = true;
for (CtTypeReference<?> param : params) {
if (!(param instanceof CtImplicitTypeReference)) {
if (!(param.isImplicit())) {
isImplicitTypeReference = false;
scan(param);
write(", ");
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/spoon/reflect/visitor/ImportScannerImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import spoon.reflect.declaration.CtEnum;
import spoon.reflect.declaration.CtInterface;
import spoon.reflect.declaration.CtType;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.reflect.reference.CtArrayTypeReference;
import spoon.reflect.reference.CtExecutableReference;
import spoon.reflect.reference.CtFieldReference;
Expand Down Expand Up @@ -173,7 +172,7 @@ public void computeImports(CtElement element) {

@Override
public boolean isImported(CtTypeReference<?> ref) {
if (!(ref instanceof CtImplicitTypeReference) && imports.containsKey(ref.getSimpleName())) {
if (!(ref.isImplicit()) && imports.containsKey(ref.getSimpleName())) {
CtTypeReference<?> exist = imports.get(ref.getSimpleName());
if (exist.getQualifiedName().equals(ref.getQualifiedName())) {
return true;
Expand Down
18 changes: 0 additions & 18 deletions src/main/java/spoon/support/DefaultInternalFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@
import spoon.reflect.factory.Factory;
import spoon.reflect.factory.InternalFactory;
import spoon.reflect.internal.CtCircularTypeReference;
import spoon.reflect.internal.CtImplicitArrayTypeReference;
import spoon.reflect.internal.CtImplicitTypeReference;
import spoon.support.reflect.internal.CtCircularTypeReferenceImpl;
import spoon.support.reflect.internal.CtImplicitArrayTypeReferenceImpl;
import spoon.support.reflect.internal.CtImplicitTypeReferenceImpl;

public class DefaultInternalFactory implements InternalFactory {
private final Factory mainFactory;
Expand All @@ -38,18 +34,4 @@ public CtCircularTypeReference createCircularTypeReference() {
e.setFactory(mainFactory);
return e;
}

@Override
public <T> CtImplicitTypeReference<T> createImplicitTypeReference() {
final CtImplicitTypeReferenceImpl<T> e = new CtImplicitTypeReferenceImpl<T>();
e.setFactory(mainFactory);
return e;
}

@Override
public <T> CtImplicitArrayTypeReference<T> createImplicitArrayTypeReference() {
final CtImplicitArrayTypeReference<T> e = new CtImplicitArrayTypeReferenceImpl<T>();
e.setFactory(mainFactory);
return e;
}
}
Loading