Lookup dynamically the declaration of all variable references #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this fully backward compatible proposal.
|
|
@monperrus Test integrated. |
|
thanks a lot for the joint work @fedorov-s-n @GerardPaligot |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for the issue #756.
On the issue, the solution proposed @fedorov-s-n was good but have 2 problems (specified by him): change the API and can throw an exception
ParentNotInitializeExceptionif the model isn't complete.Me, I propose a solution widely inspired by @fedorov-s-n (big thanks to him) but I remove disadvantages: I haven't any change in the API and I handle the exception.
What do you think about it?