support of noClassPath in getFields

[arturbosch]

…hen the parent class is not found in noClassPath-Mode

This tries to fix #775.

[monperrus]

thanks for this pull request!

this changes the intended fail-fast semantics of getActualClass. For #755, I would rather go for an appropriate try/catch in getAllFields.

[arturbosch]

Something like that?

    @Override
    public Collection<CtFieldReference<?>> getAllFields() {
        CtType<?> t = getDeclaration();
        try {
            if (t == null) {
                return RtHelper.getAllFields(getActualClass(), getFactory());
            } else {
                return t.getAllFields();
            }
        } catch (SpoonClassNotFoundException cnfe) {
            return handleParentNotFound(cnfe);
        }
    }

    private Collection<CtFieldReference<?>> handleParentNotFound(SpoonClassNotFoundException cnfe) {
        String msg = "cannot load class: " + getQualifiedName() + " with class loader "
                + Thread.currentThread().getContextClassLoader();
        if (getFactory().getEnvironment().getNoClasspath()) {
            // should not be thrown in 'noClasspath' environment (#775)
            Launcher.LOGGER.warn(msg);
            return Collections.emptyList();
        } else {
            throw cnfe;
        }
    }

Maybe you have a suggestion for a better message name. Cheers.

[arturbosch]

Furthermore getDeclaredFields has the same behaviour and maybe needs a try-catch too.

But now getXXXFields will always return an empty list even if 'Foo' has a field.

public class Foo extends Unknown {
    private String s;
...
}

[monperrus]

Something like that?

exactly. should the try/catch be around the RtHelper call directly?

[msteinbeck]

Is it worth merging now?

[GerardPaligot]

Can you remove these sout?

[arturbosch]

I incorporated all of your feedback. Sorry, I was in a hurry last time.

[GerardPaligot]

Thanks @arturbosch for your last commit but it seems that you removed your call to superclass.getAllFields();.

Can you add an assert on this call to show we don't throw anymore an exception? After that, we'll merge your PR.

[arturbosch]

Done. Is the comment ok or should I remove it ;) ?

[GerardPaligot]

Thanks @arturbosch! :)