Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 573 597 600 #799

Merged
merged 5 commits into from
Aug 25, 2016
Merged

Fix 573 597 600 #799

merged 5 commits into from
Aug 25, 2016

Conversation

GerardPaligot
Copy link
Contributor

@GerardPaligot GerardPaligot commented Aug 24, 2016

Fix #573 #597 #600

@Override
public void visitCtTypeParameterReference(CtTypeParameterReference ref) {
if (!(ref.getParent() instanceof CtReference)) {
assertEquals(ref.getSimpleName(), ref.getDeclaration().getSimpleName());
Copy link
Collaborator

@monperrus monperrus Aug 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only in Spoon mode: (ref.getDeclaration!=null) (not in rt or noclasspath mode)

@monperrus
Copy link
Collaborator

CtTypeInformation {

/** returns true if this element is a generics (eg "T") and false if it is an actual type (eg 'Book" or "String") */
isGenerics() {
....
}

}

@GerardPaligot
Copy link
Contributor Author

@monperrus PR ok.

@monperrus
Copy link
Collaborator

could you add somewhere in a test a specification of isGenerics assertTrue(isGenerics) and assertFalse(isGenerics)?

@monperrus monperrus merged commit 1b758e1 into INRIA:master Aug 25, 2016
@GerardPaligot GerardPaligot deleted the fix_573_597_600 branch August 25, 2016 11:35
@tdurieux tdurieux mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants