feature(runtime): allow to instantiate any class at any time #884

monperrus · 2016-10-05T17:11:04Z

        // contract: a ctclass can be instantiated, and each modification results in a new valid object
        Factory factory = new Launcher().getFactory();
        CtClass c = factory.Code().createCodeSnippetStatement(
                            "class X implements spoon.test.compilation.Ifoo { public int foo() {int i=0; return i;} }").compile();
        c.addModifier(ModifierKind.PUBLIC); // required otherwise java.lang.IllegalAccessException at runtime when instantiating

        CtBlock body = c.getElements(new TypeFilter<>(CtBlock.class)).get(1);
        Object o = c.newInstance();
        assertEquals(0, ((Ifoo)o).foo());
        for (int i=1; i<=10; i++) {
            body.getStatement(0).replace(factory.Code().createCodeSnippetStatement("int i = "+i+";"));
            o = c.newInstance();
            // each time the behavior has changed!
            assertEquals(i, ((Ifoo)o).foo());
        }

tdurieux · 2016-10-06T07:14:12Z

src/main/java/spoon/Launcher.java

@@ -794,6 +794,7 @@ public void setBinaryOutputDirectory(String path) {
 @Override
 public void setBinaryOutputDirectory(File outputDirectory) {
 modelBuilder.setBinaryOutputDirectory(outputDirectory);
+ getFactory().getEnvironment().setBinaryOutputDirectory(outputDirectory.getAbsolutePath());


Do not duplicate the information.
You can use the environment in the in the model builder.

tdurieux · 2016-10-06T07:16:08Z

src/main/java/spoon/support/compiler/jdt/JDTBatchCompiler.java

+ JDTBatchCompiler.this.jdtCompiler.reportProblem(problem);
+ } else {
+ new Exception().printStackTrace();
+ System.err.println(problem + " " + new String(problem.getOriginatingFileName()));


We have a logger please use it.

tdurieux · 2016-10-06T07:18:56Z

src/main/java/spoon/support/reflect/code/CtStatementImpl.java

 }
+ } catch (ParentNotInitializedException ignore) {
+ // no constructor in parent


You have this exception only because you set the parent of the CtClass to null when you use the snippet to create the class.

tdurieux · 2016-10-06T07:19:21Z

src/main/java/spoon/support/compiler/SnippetCompilationHelper.java

+ if (ret instanceof CtClass) {
+ CtClass klass = (CtClass) ret;
+ klass.setSimpleName(klass.getSimpleName().replaceAll("^[0-9]*", ""));
+ klass.setParent(null);


Use the rootPackage instead of null.

tdurieux · 2016-10-06T07:23:07Z

src/main/java/spoon/support/reflect/declaration/CtClassImpl.java

+ // cleaning afterwards
+ new File(getFactory().getEnvironment().getBinaryOutputDirectory() + "/" + getQualifiedName().replace('.', '/') + ".class").delete();
+
+ return klass.newInstance();


I think it is a good idea to force the compilation the complete project because if the user did not set shouldCompile to true, all reference to other classes of the project will produce compilation error.
Same error if the klass contains a reference to a new class created with spoon.

tdurieux · 2016-10-06T07:23:47Z

src/test/java/spoon/test/compilation/CompilationTest.java

+ Factory factory = new Launcher().getFactory();
+ CtClass c = factory.Code().createCodeSnippetStatement(
+ "class X implements spoon.test.compilation.Ifoo { public int foo() {int i=0; return i;} }").compile();
+ c.addModifier(ModifierKind.PUBLIC); // required otherwise java.lang.IllegalAccessException at runtime when instantiating


I should be nice the handle this workaround in newInstance method

GerardPaligot · 2016-10-09T14:30:23Z

src/main/java/spoon/SpoonModelBuilder.java

 /**
 * Generates the bytecode associated to the classes stored in this
 * compiler's factory. The bytecode is generated in the directory given by
 * {@link #getBinaryOutputDirectory()}.
 *
- * @see #getSourceClasspath()
- */
- boolean compile();


SpoonModelBuilder is an interface (and very exposed). Think to deprecate methods rather than remove them like this.

GerardPaligot · 2016-10-09T14:30:32Z

src/main/java/spoon/SpoonModelBuilder.java

 *
 * @see #getSourceClasspath()
 */
- boolean compileInputSources();


GerardPaligot · 2016-10-09T14:33:45Z

src/main/java/spoon/support/compiler/jdt/CompilationUnitWrapper.java

 import spoon.reflect.declaration.CtType;
 import spoon.reflect.visitor.DefaultJavaPrettyPrinter;

 import java.util.ArrayList;
 import java.util.List;

-class CompilationUnitWrapper extends CompilationUnit {
+public class CompilationUnitWrapper extends CompilationUnit {


This is really necessary to expose this class?

GerardPaligot · 2016-10-09T14:36:05Z

src/main/java/spoon/support/reflect/code/CtStatementImpl.java

 }
+ } catch (ParentNotInitializedException ignore) {
+ // no parent set somewhere


That smells bad...

tdurieux reviewed Oct 6, 2016

View reviewed changes

monperrus force-pushed the newInstance branch 12 times, most recently from 82f0737 to 6ad7f82 Compare October 7, 2016 11:39

GerardPaligot reviewed Oct 9, 2016

View reviewed changes

feature(runtime): allow to instantiate any class at any time

71211bc

monperrus force-pushed the newInstance branch from 6ad7f82 to 71211bc Compare October 10, 2016 15:25

monperrus mentioned this pull request Oct 10, 2016

Create CtTypeAccess/CtTypeReference for ArrayReferences in noclasspath mode and static context. #811

Closed

tdurieux merged commit 50a15b7 into INRIA:master Oct 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(runtime): allow to instantiate any class at any time #884

feature(runtime): allow to instantiate any class at any time #884

monperrus commented Oct 5, 2016 •

edited

Loading

tdurieux Oct 6, 2016

tdurieux Oct 6, 2016

tdurieux Oct 6, 2016

tdurieux Oct 6, 2016

tdurieux Oct 6, 2016

tdurieux Oct 6, 2016

GerardPaligot Oct 9, 2016

GerardPaligot Oct 9, 2016

GerardPaligot Oct 9, 2016

GerardPaligot Oct 9, 2016 •

edited

Loading

feature(runtime): allow to instantiate any class at any time #884

feature(runtime): allow to instantiate any class at any time #884

Conversation

monperrus commented Oct 5, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GerardPaligot Oct 9, 2016 • edited Loading

Choose a reason for hiding this comment

monperrus commented Oct 5, 2016 •

edited

Loading

GerardPaligot Oct 9, 2016 •

edited

Loading