fixed(prettyprint): parentheses are missing when pretty-pretting some ternary expressions #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ternary expressions
monperrus
reviewed
Nov 3, 2016
| CtStatement compile = snippet.compile(); | ||
|
|
||
| // Pretty-printing the Spooned code snippet and compiling the resulting code. | ||
| launcher = new Launcher(); |
There was a problem hiding this comment.
do you need a new Launcher?
monperrus
reviewed
Nov 3, 2016
| launcher = new Launcher(); | ||
| snippet = launcher.getFactory().Code().createCodeSnippetStatement(compile.toString()); | ||
| // If it throws an exception, the printed code is not valid. | ||
| snippet.compile(); |
There was a problem hiding this comment.
add an assert assertEquals(compile, snippet.compile())?
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current prettyprint of ternary expressions (CtConditional) adds parentheses around the condition only when the parent is an assignment. The added test show that parentheses are also required on variable declaration.
The test shows that the mandatory parentheses that originally surround the condition are removed when pretty-printing the spooned code. This leads to ambiguous code that does not compile.
The fix adds the parentheses when the parent is a variable declaration.
Maybe the parentheses should be always added.