fix bug: NPE when compilation units array contains null elements #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in TreeBuilderCompiler.buildUnits() where a retured array is longer then expected and the extra spaces are null. The method is updated to use the _totalUnits_ instance variable as the true element count in the _unitsToProcess_ array instead of the length of the array itself. This broke processing of classes using JDTBatchCompiler.getUnits() and expecting every element in the array to be non-null. The problem came up when trying to process the source for a large GWT project.
|
I see that #550 was merged in stable. And this was never ported to master? |
|
Correct. I happened to come back to my project using spoon and hit the error again. Reapplied the PR and things started working again. I just checked the code in the current stable branch and I don't see the change their either. |
|
sorry for that. we have a bug in the process to be fixed. |
|
No problem. Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in TreeBuilderCompiler.buildUnits() where a retured array is
longer then expected and the extra spaces are null. The method is updated
to use the totalUnits instance variable as the true element count in
the unitsToProcess array instead of the length of the array itself.
This broke processing of classes using JDTBatchCompiler.getUnits() and
expecting every element in the array to be non-null. The problem came up
when trying to process the source for a large GWT project.
This applies the fix for issue #550 to master.