Refactor - use JDTBasedSpoonCompiler.buildModel() #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, review it after #930 is finished. It is not possible to isolate them. There would be conflict anyway. |
pvojtechovsky
force-pushed
the
refactorShared_buildModel
branch
from
0f8d5cf
to
5561de6
Compare
|
you can now rebase to have a clear PR |
pvojtechovsky
force-pushed
the
refactorShared_buildModel
branch
from
5561de6
to
a8b3855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method JDTBasedSpoonCompiler.buildModel() was created and called on 3 places instead of 3 times implemented/copied code.
This PR depends on #930