fix(test): much stronger contracts for setter spec and tests #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
force-pushed
the
test-parent2
branch
3 times, most recently
from
64e9b36
to
700141f
Compare
monperrus
changed the title
monperrus
force-pushed
the
test-parent2
branch
from
700141f
to
40a7e85
Compare
monperrus
changed the title
monperrus
force-pushed
the
test-parent2
branch
from
40a7e85
to
6feac34
Compare
tdurieux
reviewed
Nov 17, 2016
| getExecutable().setType(type); | ||
| type.setParent(this); |
tdurieux
reviewed
Nov 17, 2016
| getExecutable().setType(type); | ||
| type.setParent(this); |
monperrus
force-pushed
the
test-parent2
branch
from
6feac34
to
b213c99
Compare
monperrus
force-pushed
the
test-parent2
branch
from
b213c99
to
b510f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behavior: all setters are fail-safe: if they don't make sense on a certain type, they do nothing (instead of throwing an exception).
This is better because:
@UnsettableAnnotationNew testing strategy: we test all setters:
By doing this, we fix a couple of bugs a parent of references.
and also removed the duplicate
ParentTestclass.