Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(position): improve the element positions #984

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

tdurieux
Copy link
Collaborator

No description provided.

@tdurieux tdurieux force-pushed the feat_position branch 3 times, most recently from 2b68632 to 769674e Compare November 17, 2016 15:22
@@ -14,16 +14,67 @@
* The fact that you are presently reading this means that you have had
* knowledge of the CeCILL-C license and that you accept its terms.
*/
package spoon.reflect.cu;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in same package

@@ -376,7 +379,30 @@
*/
SourcePosition createSourcePosition(
CompilationUnit compilationUnit,
int startDeclaration, int startSource, int end, int[] lineSeparatorPositions);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monperrus
Copy link
Collaborator

some doc in /doc

@tdurieux tdurieux force-pushed the feat_position branch 4 times, most recently from bff6a48 to 118ec53 Compare November 21, 2016 22:19
public interface SourcePosition {
public interface SourcePosition extends Serializable {

SourcePosition NOPOSITION = new SourcePosition() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singleton outside, declaration here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants