Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(array): the qualified name of an array is not java.lang.reflect.Array #995

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

monperrus
Copy link
Collaborator

@monperrus monperrus commented Nov 20, 2016

java.lang.reflect.Array only contains static utility methods and is not all all a superclass of arrays.

(new int[0]).getClass().getCanonicalName() gives int[] which should be the result of Spoon.

the removal of the defensive exception is required, because of the presence of another cryptic yet not critical bug (a TypeReference which should be a a TypeParameterReference while cloning).

this fix is also a prerequisite to another fix on equality to come later.

@tdurieux tdurieux merged commit 498f5b5 into INRIA:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants