Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(equal): actual type refs must be part of equality #997

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

monperrus
Copy link
Collaborator

@monperrus monperrus commented Nov 22, 2016

this fixes a very old and deep bug, which was enforced in certain existing assertions.

but now we have the expected:

CtLocalVariable var = factory.Code().createCodeSnippetStatement("java.util.List<String> l ").compile();
CtLocalVariable var2 = factory.Code().createCodeSnippetStatement("java.util.List<Object> l ").compile();
assertNotEquals(var2, var); // the generics are taken into account

(this holds for any actual type parameter).

@monperrus monperrus force-pushed the fix-equal-typref-actualtypeparams branch 3 times, most recently from 35bf2fc to f05fb4d Compare November 22, 2016 21:01
@monperrus monperrus force-pushed the fix-equal-typref-actualtypeparams branch from f05fb4d to 46733c4 Compare November 22, 2016 21:12
@monperrus
Copy link
Collaborator Author

@tdurieux ready for merging.

@tdurieux tdurieux merged commit 8ec56ba into INRIA:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants