Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL_endLifespanVersion has multiplicity 1 #42

Closed
sMorrone opened this issue Oct 10, 2021 · 2 comments · Fixed by #52, #53 or #54
Closed

EL_endLifespanVersion has multiplicity 1 #42

sMorrone opened this issue Oct 10, 2021 · 2 comments · Fixed by #52, #53 or #54
Labels
endorsed The change proposal is endorsed by the MIG. impact on TG The change proposal has an impact on the TG. impact on UML The change proposal has an impact on the UML diagram. non-breaking change The change proposal does not prevent backward compatibility of the schema
Milestone
2022.2

Comments

@sMorrone
Copy link
Collaborator

sMorrone commented Oct 10, 2021 •
edited by fabiovinci
Loading

Change proposal description

In ElevationGridCoverage , ElevationTIN and ElevationVectorElements application schemas the 'endLifespanVersion' property has multiplicity equal to one.
Proposal is to set endLifespanVersion multiplicity to [0..1], coherently to multiplicity of this property in the other INSPIRE application schemas.

Issue faced

In most cases the endLifespanVersion is not known, but, since multiplicity of this element is 1, a value or a nilReason shall be provided.

Proposed solution

Add minOccurs=0 to the endLifespanVersion definition

Technical details

the current property definition
image
is changed to
image

Addressed schemas

https://inspire.ec.europa.eu/schemas/el-vec/4.0/ElevationVectorElements.xsd,
https://inspire.ec.europa.eu/schemas/el-cov/4.0/ElevationGridCoverage.xsd
https://inspire.ec.europa.eu/schemas/el-tin/4.0/ElevationTin.xsd

Impact on INSPIRE TG / IR

TG (related issue INSPIRE-MIF/technical-guidelines#25) and UML impacted

Change proposer

Proposal was discussed in the INSPIRE Community Forum.

References

More detailed documentation

https://wayback.archive-it.org/12090/20210119145601/https://inspire.ec.europa.eu/forum/discussion/view/266001/the-endlifespanversion-property-has-minimum-cardinality-equal-to-one-in-the-elevation-schema
@heidivanparys heidivanparys added this to the 2022.2 milestone Oct 29, 2021
sMorrone added a commit that referenced this issue Dec 6, 2021
@sMorrone
Made endLifespanVersion property optional
d64fbfd 
Added minOccurs=0 to the endLifespanVersion - see issue #42
This was referenced Dec 6, 2021
Merged
Merged
sMorrone added a commit that referenced this issue Dec 14, 2021
@sMorrone
Update ElevationTIN.xsd to make endlifespanVersion optional
a3536ac 
Added minOccurs=0 to the endLifespanVersion definition - related issue #42
This was referenced Dec 14, 2021
Merged
Closed
@MarcoMinghini MarcoMinghini added the impact on TG The change proposal has an impact on the TG. label Dec 14, 2021
@sMorrone sMorrone added for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. impact on TG The change proposal has an impact on the TG. and removed impact on TG The change proposal has an impact on the TG. labels Dec 15, 2021
@sMorrone
Copy link
Collaborator Author

Subgroup Meeting 15-12-2021: Change proposal is approved

This was linked to pull requests Mar 11, 2022
Update ElevationVectorElements.xsd to make endLifespanVersion optional #52
Merged
Update ElevationGridCoverage.xsd to make endLifespanVersion optional #53
Merged
Update ElevationTIN.xsd to make endlifespanVersion optional #54
Merged
@fabiovinci fabiovinci added the impact on UML The change proposal has an impact on the UML diagram. label Mar 14, 2022
@fabiovinci fabiovinci added the non-breaking change The change proposal does not prevent backward compatibility of the schema label Mar 30, 2022
@sMorrone
Copy link
Collaborator Author

sMorrone commented Apr 4, 2022

During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was endorsed.
More details in the meeting minutes on the 69th MIG-T meeting page

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. labels Apr 4, 2022
fabiovinci added a commit that referenced this issue Aug 2, 2022
@sMorrone @fabiovinci
Update ElevationVectorElements.xsd to make endLifespanVersion optional (
f8747fc 
#52)

* Made endLifespanVersion property optional

Added minOccurs=0 to the endLifespanVersion - see issue #42

* Add changelog and version

Add a comment with changelog and update the version

Co-authored-by: Fabio Vinci <f.vinci@epsilon-italia.it>
fabiovinci added a commit that referenced this issue Aug 2, 2022
@sMorrone @fabiovinci
Update ElevationTIN.xsd to make endlifespanVersion optional (#54)
fb11964 
* Update ElevationTIN.xsd to make endlifespanVersion optional

Added minOccurs=0 to the endLifespanVersion definition - related issue #42

* Add changelog and version

Add a comment with changelog and update the version

* Update version

Co-authored-by: Fabio Vinci <f.vinci@epsilon-italia.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
endorsed The change proposal is endorsed by the MIG. impact on TG The change proposal has an impact on the TG. impact on UML The change proposal has an impact on the UML diagram. non-breaking change The change proposal does not prevent backward compatibility of the schema
Projects
None yet
Milestone
2022.2
4 participants
@heidivanparys @sMorrone @MarcoMinghini @fabiovinci