Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Croatian language to the common.xsd schema #7

Closed
Ana-SGA opened this issue Jun 15, 2021 · 17 comments · Fixed by #55
Closed

Add Croatian language to the common.xsd schema #7

Ana-SGA opened this issue Jun 15, 2021 · 17 comments · Fixed by #55
Labels
endorsed The change proposal is endorsed by the MIG.
Milestone

Comments

@Ana-SGA
Copy link

Ana-SGA commented Jun 15, 2021

Dear all,

as @heidivanparys suggested in #547, Croatian language ("hrv") should be added to the https://inspire.ec.europa.eu/schemas/common/1.0/common.xsd.

For now, the INSPIRE Validator returns an error on Croatian language as seen below:

Language_hrv

@sMorrone sMorrone added for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. and removed for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. labels Jun 15, 2021
@heidivanparys
Copy link
Collaborator

I created a branch for doing this, see https://github.com/INSPIRE-MIF/application-schemas/tree/issue_7.

There is an outstanding issue with the URI for the IR interoperability. Using OJ:L:2010:323:0011:0102:HR:PDF does not work, I assume this is because of the following (from https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=celex%3A32010R1089):

OJ L 323, 8.12.2010, p. 11–102 (BG, ES, CS, DA, DE, ET, EL, EN, FR, IT, LV, LT, HU, MT, NL, PL, PT, RO, SK, SL, FI, SV)
Special edition in Croatian: Chapter 16 Volume 003 P. 98 - 189

@MarcoMinghini @alexanderkotsev Who can help to determine the correct URI?

The relevant locations:

<xs:enumeration value="TODO"/>

<xs:enumeration value="TODO"/>

Compare e.g. to

<xs:enumeration value="http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:DA:PDF"/>

and

<xs:enumeration value="OJ:L:2010:323:0011:0102:DA:PDF"/>

I am also in doubt about which version to use. I put in 1.0.0 for now.

<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns="http://inspire.ec.europa.eu/schemas/common/1.0" targetNamespace="http://inspire.ec.europa.eu/schemas/common/1.0" elementFormDefault="qualified" attributeFormDefault="unqualified" version="1.0.0">

@sMorrone
Copy link
Collaborator

We should check if it works with the CELEX number https://eur-lex.europa.eu/legal-content/HR/TXT/PDF/?uri=CELEX:32010R1089&from=EN (it should ) otherwise we should look for the special edition of the journal where they added the Croatian language ...

@heidivanparys
Copy link
Collaborator

There are two places we need a solution for: the inspire_common:Conformity/inspire_common:Specification/inspire_common:URI element and the inspire_common:Conformity/inspire_common:Specification/inspire_common:ResourceLocator/inspire_common:URL element.

An extract of a Capabilities file using those elements:

<csw:Capabilities>
	<!-- More elements here... -->
	<inspire_ds:ExtendedCapabilities>
		<!-- More elements here... -->
		<inspire_common:Conformity>
			<inspire_common:Specification xsi:type="inspire_common:citationInspireInteroperabilityRegulation_eng">
				<inspire_common:Title>COMMISSION REGULATION (EU) No 1089/2010 of 23 November 2010 implementing Directive 2007/2/EC of the European Parliament and of the Council as regards interoperability of spatial data sets and services</inspire_common:Title>
				<inspire_common:DateOfPublication>2010-12-08</inspire_common:DateOfPublication>
				<inspire_common:URI>OJ:L:2010:323:0011:0102:EN:PDF</inspire_common:URI>
				<inspire_common:ResourceLocator>
					<inspire_common:URL>http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:EN:PDF</inspire_common:URL>
					<inspire_common:MediaType>application/pdf</inspire_common:MediaType>
				</inspire_common:ResourceLocator>
			</inspire_common:Specification>
			<inspire_common:Degree>conformant</inspire_common:Degree>
		</inspire_common:Conformity>
		<!-- More elements here... -->
	</inspire_ds:ExtendedCapabilities>
	<!-- More elements here... -->
</csw:Capabilities>

Regarding the inspire_common:Conformity/inspire_common:Specification/inspire_common:ResourceLocator/inspire_common:URL element, the schemas for the other languages use a link like:

http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:<two letter language code>:PDF

For the existing languages, that link resolves, but that pattern does not work for Croatian:

Using the CELEX number – and what seems to be a more recent URL pattern – the PDF can be retrieved indeed (and that same pattern also works for the other languages):

The main point of the inspire_common:Conformity/inspire_common:Specification/inspire_common:ResourceLocator/inspire_common:URL is as far as I can see a resolvable URL (the documentation of it states "One or more URLs if available", see https://inspire.ec.europa.eu/schemas/common/1.0/common.xsd), so I guess https://eur-lex.europa.eu/legal-content/HR/TXT/PDF/?uri=CELEX:32010R1089 would be acceptable indeed, but that would need to be confirmed.

Regarding the inspire_common:Conformity/inspire_common:Specification/inspire_common:URI element (the documentation of it states "One or more Documentation URIs if available", see https://inspire.ec.europa.eu/schemas/common/1.0/common.xsd), notice the following pattern for all languages apart from Croatian:

image

But what is the official URI for the Croatian version?

image

@heidivanparys
Copy link
Collaborator

Subgroup meeting 01-07-2021: Newer and unofficial versions of the "common" schemas are present at https://inspire-geoportal.ec.europa.eu/schemas/ (including https://inspire-geoportal.ec.europa.eu/schemas/inspire/common/1.0/enums/enum_dut.xsd). Those newer versions should be submitted in this repository, going through the governance process.

The Croatian language is already added in those versions, see https://inspire-geoportal.ec.europa.eu/schemas/inspire/common/1.0/common.xsd and https://inspire-geoportal.ec.europa.eu/schemas/inspire/common/1.0/enums/enum_hrv.xsd.

The correct URIs for the Croatian documents should still be double-checked.

@sMorrone sMorrone added further info required Further info is required to the change proposal. and removed for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. labels Jul 2, 2021
@sMorrone
Copy link
Collaborator

sMorrone commented Jul 2, 2021

Subgroup meeting 01-07-2021: this issue must be further investigated to define the exact changes to be made.

@sMorrone sMorrone added the for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. label Jul 4, 2021
@MarcoMinghini
Copy link
Contributor

The INSPIRE CT approved the change proposal during today's meeting. In the next step, the proposal will be moved to the MIG for the final endorsement.

URIs for Croatian documents to be still double-checked.

@MarcoMinghini MarcoMinghini added for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. and removed for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. labels Jul 6, 2021
@Ana-SGA
Copy link
Author

Ana-SGA commented Jul 7, 2021

Dear all,

thanks for including the Croatian language :)

I've asked eur-lex helpdesk for help with the uri, don't know if it can help, but this is what I received today:

You may use as an alternative the format below in order to download the respective documents (identifier type:oj):
http://eur-lex.europa.eu/legal-content/HR/TXT/PDF/?uri=OJ:JOL_2010_323_R_0011_01
http://eur-lex.europa.eu/legal-content/DA/TXT/PDF/?uri=OJ:JOL_2010_323_R_0011_01
http://eur-lex.europa.eu/legal-content/IT/TXT/PDF/?uri=OJ:JOL_2010_323_R_0011_01
http://eur-lex.europa.eu/legal-content/EN/TXT/PDF/?uri=OJ:JOL_2010_323_R_0011_01

or the format(identifier type:celex):
https://eur-lex.europa.eu/legal-content/HR/TXT/PDF/?uri=CELEX:32010R1089
https://eur-lex.europa.eu/legal-content/DA/TXT/PDF/?uri=CELEX:32010R1089
https://eur-lex.europa.eu/legal-content/IT/TXT/PDF/?uri=CELEX:32010R1089
https://eur-lex.europa.eu/legal-content/EN/TXT/PDF/?uri=CELEX:32010R1089

Please also note that the links below are obsolete:
http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:EN:PDF
http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:DA:PDF
http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:IT:PDF
http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=OJ:L:2010:323:0011:0102:HR:PDF

We recommend the links via identifier type uriserv to be built as follows (new version of EUR-Lex links):
https://eur-lex.europa.eu/legal-content/EN/TXT/PDF/?uri=uriserv:OJ.L_.2010.323.01.0011.01.ENG
https://eur-lex.europa.eu/legal-content/DA/TXT/PDF/?uri=uriserv:OJ.L_.2010.323.01.0011.01.DAN
https://eur-lex.europa.eu/legal-content/IT/TXT/PDF/?uri=uriserv:OJ.L_.2010.323.01.0011.01.ITA
But still, the HR version via uriserv, indeed does not exist as you reported:
https://eur-lex.europa.eu/legal-content/HR/TXT/PDF/?uri=uriserv:OJ.L_.2010.323.01.0011.01.HRV
This is due to the fact that the respective document is published in a Special edition in Croatian which can be accessed via:
https://eur-lex.europa.eu/legal-content/HR/TXT/PDF/?uri=uriserv:DD.HRV.16.003.FULL

In principal, from the Official Journal to the acts the relation is done with uriserv identifiers. This allows linking non synoptic OJs from the beginning to the correct act.
For the Special Official Journal editions we have the advantage to know the celex to which the toc should be binding, so we do not need the uriserv identifier.

You may download the XML notice of 32010R1089 document:

cellar_6c9b0d4b-831f-47fe-b551-ac13604d9797.xml

In the XPATH (/NOTICE/WORK/WORK_HAS_EXPRESSION[17]/SAMEAS/URI) and the respective expression of HRV language you may confirm that there is no identifier of type uriserv (only of type cellar, celex and oj).

@MarcoMinghini
Copy link
Contributor

The INSPIRE MIG approved the change proposal, since no objections were raised during the two week scrutiny period from July 12 to July 26, 2021. The change can be now implemented.

@MarcoMinghini MarcoMinghini added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. labels Aug 6, 2021
@Ana-SGA
Copy link
Author

Ana-SGA commented Sep 6, 2021

Dear @MarcoMinghini,

could you please tell me when this change will be implemented?

@MarcoMinghini
Copy link
Contributor

Dear @Ana-SGA,
the change proposal was endorsed by the MIG, but further details are still required to specify the exact changes to be made. The release depends on when the related pull request will be agreed and done. This can be further discussed in the next sub-group meeting on September 16, 2021.

@Ana-SGA
Copy link
Author

Ana-SGA commented Sep 6, 2021

Dear @MarcoMinghini,
what determines whether it will be discussed by the sub-group? Is it necessary to make a query/request somewhere?
Thanks for all the info!

@heidivanparys heidivanparys added this to the 2022.1 milestone Oct 29, 2021
heidivanparys added a commit to heidivanparys/application-schemas that referenced this issue Dec 15, 2021
Different types of identifiers are supported (oj, celex and uriserv),
see also INSPIRE-MIF#7 (comment)
@heidivanparys heidivanparys linked a pull request Dec 15, 2021 that will close this issue
@sMorrone sMorrone removed the further info required Further info is required to the change proposal. label Dec 15, 2021
@sMorrone
Copy link
Collaborator

Issue discussed in subgroup meeting on 15/12/21. Agreed to update both the common.xsd (adding reference to enums/enum_hrv.xsd) and the enum_hrv.xsd (adding working link to IR in Croatian Language).

@Ana-SGA
Copy link
Author

Ana-SGA commented Dec 15, 2021

Dear @sMorrone ,
that's great news. When could changes be implemented?

@heidivanparys
Copy link
Collaborator

Issue discussed in subgroup meeting on 15/12/21. Agreed to update both the common.xsd (adding reference to enums/enum_hrv.xsd) and the enum_hrv.xsd (adding working link to IR in Croatian Language).

See INSPIRE-MIF/technical-guidelines#72.

@sMorrone
Copy link
Collaborator

Dear @Ana-SGA,
the modified schemas will be included in release 2022.1, foreseen by end of January

@Ana-SGA
Copy link
Author

Ana-SGA commented Dec 15, 2021

Dear @sMorrone ,
thanks, glad you all put it through! Now we have left the inclusion of the official reference coordinate system of the Republic of Croatia EPSG:3765 :) mentioned in #38

Do you or maybe @heidivanparys now if I should open new issue for the CRS?

@heidivanparys
Copy link
Collaborator

Now we have left the inclusion of the official reference coordinate system of the Republic of Croatia EPSG:3765 :) mentioned in #38

Do you or maybe @heidivanparys now if I should open new issue for the CRS?

You could open an issue in the helpdesk, and we'll label it with CRS registry, as we have to wait for:

  1. Amendment to IR 1089/2010 to allow for a CRS registry to be established (the procedure for this amendment is ongoing: it has been in public consultation, and the INSPIRE Committee members had until the 10th of December to express their opinion).
  2. Creation of a CRS registry, including governance structure with a control body.
  3. Update of the validator to validate against the CRS registry instead of against the current static list.
  4. Approval of the control body to add the Croatian CRSs to the CRS registry (i.e., confirmation of the control body that these CRSs fulfil the requirements in the amended implementing rules).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants