Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG Download - dataset identifier namespace is optional #82

Closed
heidivanparys opened this issue Dec 21, 2022 · 8 comments · Fixed by #83
Closed

TG Download - dataset identifier namespace is optional #82

heidivanparys opened this issue Dec 21, 2022 · 8 comments · Fixed by #83
Labels
endorsed The change proposal is endorsed by the MIG. impact on schemas The change proposal has an impact on the INSPIRE XML .Schemas impact on validator The change proposal has an impact on the INSPIRE validator.
Milestone

Comments

@heidivanparys
Copy link
Collaborator

heidivanparys commented Dec 21, 2022

Change proposal description

The namespace component of the dataset identifier is optional, the requirements in the TG Download should reflect this.

Addressed TG

Technical Guidance for the implementation of INSPIRE Download Services

Location

Make spatial_dataset_identifier_namespace optional in requirements 13, 42, 43, 44, 50 and 51.

Issue faced

The namespace component of the dataset identifier is optional, in fact it is actually recommended to have a dataset identifier that is encoded in one string, containing both namespace and code, see https://inspire-mif.github.io/technical-guidelines/metadata/metadata-iso19139/metadata-iso19139.html#_unique_resource_identifier. The requirements in the TG Download do not reflect this.

Proposed solution

Update of the TG requirements 13, 42, 43, 44, 50 and 51 and the surrounding text, see pull request.

Pull request

#83

Additional information

Relevant legislation

https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX:02008R1205-20081224

Impact on IR

N/A

Impact on INSPIRE validator

Impact on:

Linked issue

INSPIRE-MIF/helpdesk-validator#124
inspire-eu-validation/download-service#89

Impact on INSPIRE XML schemas

N/A

Impact on INSPIRE code lists

N/A

Change proposer

Heidi Vanparys, Danish Agency for Data Supply and Infrastructure

References

N/A

@fabiovinci fabiovinci added the for Sub-group The change proposal is to be assessed by the Sub-group label Dec 21, 2022
@fabiovinci fabiovinci linked a pull request Dec 22, 2022 that will close this issue
@fabiovinci fabiovinci added the impact on validator The change proposal has an impact on the INSPIRE validator. label Apr 13, 2023
@heidivanparys
Copy link
Collaborator Author

To ease the discussion, some examples below.

DK INSPIRE Administrative units has the following spatial data set identifier:

billede

billede

This is in accordance with the recommendation to have a dataset identifier that is encoded in one string, containing both namespace and code, see https://github.com/INSPIRE-MIF/technical-guidelines/blob/2022.2/metadata/metadata-iso19139/metadata-iso19139.adoc#3121-unique-resource-identifier.

In the Atom feed, the spatial data set identifier is currently indicated as follows:

billede

So the spatial_dataset_identifier_namespace element is not present here.

However, this conflicts with the requirement in section Download Service Feed: feed 'entry' element:

billede

In comparison, INSPIRE - Unités Administratives - UrbIS has the following spatial data set identifier:

billede

billede

This spatial data set identifier is also compliant to the INSPIRE specifications, it's just another way of encoding it.

In the Atom feed, the spatial data set identifier is currently indicated as follows:

billede

@fabiovinci
Copy link
Collaborator

Sub-group meeting on 17.04.2023:
the issue was discussed in the sub-group and it was decided to postpone it to better verify if there are implications in other requirements of the same TG and/or in other TGs.

@fabiovinci
Copy link
Collaborator

According to this change proposal, Requirement 44 should also be reformulated.

image

@fabiovinci
Copy link
Collaborator

The change should also involve Requirement 43 since the Validator checks the mandatory presence of the "spatial_dataset_identifier_namespace" element in the Get Spatial Data Set template.

image

@heidivanparys
Copy link
Collaborator Author

heidivanparys commented Jul 1, 2023

This also affects requirement 42. I've updated the change proposal and the pull request.

@fabiovinci
Copy link
Collaborator

Sub-group meeting on 10.11.2023:
the Sub-group approved this change proposal.

@fabiovinci fabiovinci added for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. and removed for Sub-group The change proposal is to be assessed by the Sub-group labels Nov 13, 2023
@MarcoMinghini MarcoMinghini added the for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. label Nov 13, 2023
@sMorrone
Copy link
Collaborator

sMorrone commented Dec 1, 2023

During the joint MIG/MIG-T meeting held on 30/11/2023, the proposal was endorsed.
More details in the minutes of the 76th MIG-T meeting

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. labels Dec 1, 2023
@fabiovinci fabiovinci added this to the 2024.1 milestone Dec 1, 2023
@fabiovinci fabiovinci added the impact on schemas The change proposal has an impact on the INSPIRE XML .Schemas label May 17, 2024
@fabiovinci
Copy link
Collaborator

It seems that this issue also has an impact on schemas.
In particular, the schema https://inspire.ec.europa.eu/schemas/inspire_dls/1.0/inspire_dls.xsd defines elements to be used in an ATOM feed and the attribute spatial_dataset_identifier_namespace is mandatory.

Even if the schema is not used for ATOM validation, it is worth modifying it by setting the attribute spatial_dataset_identifier_namespace as optional.

image

On the contrary, the type inspire_common:uniqueResourceIdentifier defined by the https://inspire.ec.europa.eu/schemas/common/1.0/common.xsd schema and used for the SpatialDataSetIdentifier attribute of the WMS/WFS Extended capabilities is already correctly defined, i.e. the attribute inspire_common:Namespace is optional.

image

fabiovinci added a commit to inspire-eu-validation/download-atom that referenced this issue Nov 24, 2024
Update of the test according to the related TG change proposal INSPIRE-MIF/technical-guidelines#82
fabiovinci added a commit to inspire-eu-validation/download-atom that referenced this issue Nov 24, 2024
Update of the test according to the Validator issue (INSPIRE-MIF/helpdesk-validator#124) and the related TG change proposal (INSPIRE-MIF/technical-guidelines#82).
fabiovinci added a commit to inspire-eu-validation/download-atom that referenced this issue Nov 24, 2024
Update of the test according to the Validator issue (INSPIRE-MIF/helpdesk-validator#124) and the related TG change proposal (INSPIRE-MIF/technical-guidelines#82).
fabiovinci added a commit to inspire-eu-validation/download-atom that referenced this issue Nov 24, 2024
Update of the test according to the Validator issue (INSPIRE-MIF/helpdesk-validator#124) and the related TG change proposal (INSPIRE-MIF/technical-guidelines#82).
fabiovinci added a commit to inspire-eu-validation/download-wfs that referenced this issue Nov 24, 2024
Update of the test according to the Validator issue (INSPIRE-MIF/helpdesk-validator#124) and the related TG change proposal (INSPIRE-MIF/technical-guidelines#82).
fabiovinci added a commit to inspire-eu-validation/download-atom that referenced this issue Nov 24, 2024
Update of the test according to the Validator issue (INSPIRE-MIF/helpdesk-validator#124) and the related TG change proposal (INSPIRE-MIF/technical-guidelines#82).
fabiovinci added a commit to inspire-eu-validation/download-wfs that referenced this issue Nov 24, 2024
Update of the test according to the Validator issue (INSPIRE-MIF/helpdesk-validator#124) and the related TG change proposal (INSPIRE-MIF/technical-guidelines#82).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG. impact on schemas The change proposal has an impact on the INSPIRE XML .Schemas impact on validator The change proposal has an impact on the INSPIRE validator.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants