-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Start documenting the various warning/error codes #741
Comments
I agree, but having this is really hard. IMHO warnings should be self explanatory, so the best is to refine the message. |
I think it could be as simple as having a wiki page (here on gh) with the page-title/filename of the warning, with a kibot specific prefix (maybe we should do that generally anyway, e.g. instead of W102, KIB102 (KB is knowledge base often) KBOT102 also works? :p While filling these pages is the really really hard part, making a start is useful. Something like defining a (simple) markdown template, As for the self-explanatory messages, I wholeheartedly agree of course. While I had some warnings that reported things with empty quotes, making it even harder to figure out; something like 'got As for my actual problem, https://gitlab.com/olliver/esptron/-/jobs/8645487143 is my pipeline job that failed, and no, I am not supplying the PCB file, only the root schematic, the PCB file is 'auto discovered' and this works fine for all other jobs, just export is failing. |
I don't like the idea of changing warning codes.
Who will populate it? Having 171 templates won't help.
Just report it, but with an example.
Auto discovered should be ok. You should try to isolate the issue, I visited your link and it goes to a repo with no files and a protected branch. If you provide a simple test case (PCB + SCH + standalone KiBot config) I can take a look at the reason and add a better description. In fact you should try the current dev code, which should inform if the PCB file name is missing. |
Me neither, but 'W102' becomes impossible to google;
True, they'd be only placeholders and help with the google index. Populating would still be manual of course; And since it'd be the wiki, editing would be much more trivial. Having nothing will make it harder to discover (where should I put this) and will not add it to any index.
The idea of course is to reduce the number of reports, when people can self diagnose and repair the issue of course :)
The link is the pipeline job, which ran for the merge-request !1 which has the files on its own branch. Sorry for not mentioning that. Meanwhile, I'll try the dev branch. But creating a simple example might be harder, when I don't know what the problem really is of course. |
I found the source of the issue, no need to create a test case. But is simple: Q200 is 2 transistors with 1 footprint. |
Nice!! Ill try out the dev branch!
|
Note that the dev images were updated a few minutes ago. |
Many linters, such as shellcheck or markdown for example, have extensive documentation on the various error codes. Searching for these codes helps one understand and fix problems.
For example https://github.com/koalaman/shellcheck/wiki/SC2250 or https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md001---heading-levels-should-only-increment-by-one-level-at-a-time
With KiBot, it becomes quite hard to figure what an error code means and how to potentially resolve it.
The text was updated successfully, but these errors were encountered: