Mk/review/kh/fix/make file settings configurable #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
spaces vs tabs Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
add exception test Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
remove tests since it added earlier Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
extend test with 3-rd required attribute Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
fix function logic add more extensive test Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
bromiesTM
force-pushed
the
kh/fix/make-file-settings-configurable
branch
3 times, most recently
from
fbd9975 to
07e1a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist