Code cleanup #136
Merged
Code cleanup #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- export S3 methods, even if corresponding generic is not exported - document the sentinel "_PACKAGE" rather than using @doctype
- two tests fail because the length of the return value has changed (from
17 to 18 list elements)
- hard to know how the return value has changed -- simple additiion? of
which element? etc
- assume the change does not break code
- make more robust by checking for set equality of current and returned
names
- reduce messages from `readr::read_csv()` by providing
`col_classes = FALSE` argument
- silence progress in test-search.R by adding `verbose = TRUE`
- 'license' is now a list; print the 'name' - 'length(x$files)` is incorrect for a data.frame, use `NROW()`
mtmorgan
commented
Sep 15, 2024
mtmorgan
commented
Sep 15, 2024
6 tasks
…t -- the"doi:" prefix is not necessary
|
Looks good to me pending the license discussion above. One R-CMD-check Actions check is erroring out with a system library issue; not sure if it will solve itself in a few days 
|
- handle previous as well as current 'License' format
Also no need to setequal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Improves/smooths tests by @mtmorgan
Specific minor uncertainties are indicated as comments below. [edit:resolved]