File upload: alert when a file could not be added for upload #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With each upload, all files need to have a unique combination of the label (directory) and the file name. Until now, when adding the same file (as already present in the list of files to be added at the bottom of the file upload page), it is silently ignored and is not uploaded. This PR adds an alert on the top of the page when this happens to notify the user that the file could not be added.
Note that you can still add the same file multiple times to the dataset by uploading them one by one. The upload page does not check the file names of the files already present in the dataset. When the same file is uploaded again, it is handled in the standard way by the Dataverse API and gets the "-1" suffix, e.g., after adding "test.json" twice, you will have two files in the dataset: "test.json" and "test-1.json".
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Add the same file for upload twice, when adding second time (and the previously added files is still in the list of the files to be added at the bottom of the upload page), an alert should be shown (and the file is not added second time).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: