Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with demo link #491

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update README with demo link #491

merged 2 commits into from
Sep 18, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Sep 16, 2024

What this PR does / why we need it:

Updates the README file with demo link

@GPortas GPortas added the GREI Re-arch GREI re-architecture-related label Sep 16, 2024
@coveralls
Copy link

coveralls commented Sep 16, 2024

Coverage Status

coverage: 97.396%. remained the same
when pulling 33a65ea on readme_update_demos
into bf9e6d8 on develop.

@pdurbin pdurbin self-assigned this Sep 17, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question for @GPortas

README.md Outdated
Comment on lines 443 to 447

[_video_demo_filetable_url]: https://groups.google.com/g/dataverse-community/c/w_rEMddESYc/m/6F7QC1p-AgAJ

<!-- September, 2024 -->
[_video_demo_collectionpage_creationpages_fileuploading_url]: https://groups.google.com/g/dataverse-community/c/heSnBRhhriM/m/bFgLDvvZAQAJ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why these links are repeated here. Should we just delete them? Or add a comment about why they need to be maintained in two places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all Markdown variables related to demo videos, as they were not used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

@GPortas GPortas removed their assignment Sep 18, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pdurbin pdurbin removed their assignment Sep 18, 2024
@GPortas GPortas merged commit 3261cfa into develop Sep 18, 2024
10 of 14 checks passed
@GPortas GPortas deleted the readme_update_demos branch September 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI Re-arch GREI re-architecture-related
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

3 participants