allow API token to be retrieved from environment variable #24 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolapasta
reviewed
Oct 29, 2020
| @@ -33,6 +33,8 @@ Copy `dvconfig.py.sample` to `dvconfig.py` (see the `cp` command below) and add | |||
| cp dvconfig.py.sample dvconfig.py | |||
| vi dvconfig.py | |||
|
|
|||
| Note that the environment variable `$API_TOKEN` will override `api_token` in `dvconfig.py`. | |||
There was a problem hiding this comment.
My only question here is which token should take precedence, the environment variable or the one in dvconfig.py? (I have not looked at this code very deeply overall, so not necessarily advocating for the switch)
There was a problem hiding this comment.
I searched online and it seems standard for environment variable to take precedence.
scolapasta
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24 - Allow API token to be retrieved from an environment variable
I'm aware that there's a similar solution in pull request #14
I'm also aware that here the dvconfig.py file is edited directly: https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/56ae75de0a796e515200d6830115f60e6ce3fd5e/tasks/sampledata.yml#L59
This is a small chunk and makes things easier for me.