Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding metadatablock files for The Negotiation Data Repository #156

Merged
merged 1 commit into from
May 5, 2022

Conversation

jggautier
Copy link
Collaborator

@jggautier jggautier commented Apr 27, 2022

Closes #145

Adds the metadatablock TSV properties files to this GitHub repository's "metadatablocks" directory.

Note the block expects a Dataverse collection with alias 'NegotiationDataRepository' to exist. (on prod: https://dataverse.harvard.edu/dataverse/NegotiationDataRepository )

For this to be done, after QA, to sanity check the block, the last step is to load into production.

@scolapasta
Copy link

Looks fine. One thought I have is about the setup script (it's not part of this PR it just loads all). If the dv's don't exist it puts them at root. So I wonder if we should somehow have the script first add the dv's. Of course it would have to know what to give them for an alias in some way.... (this might be out of scope for this issue). Thoughts @jggautier @pdurbin ?

@jggautier
Copy link
Collaborator Author

jggautier commented May 3, 2022

Hey @scolapasta. I'm not too sure what the setup script does. Would this be how the metadatablock is added to a "production" server, like the Harvard Dataverse Repository? If so, so far whenever I've been involved in creating a metadatablock for only one collection, the collection's already created. But I think your idea wouldn't hurt.

If it's for testing/QA, I think your idea sounds helpful. I think that when @kcondon was testing, the fact that a collection with the right alias wasn't already created in the test server he was using was a bit of a hiccup.

@pdurbin
Copy link
Member

pdurbin commented May 4, 2022

I'd say the script is out of scope. To me the current effort is about making the Negotiation Data fields available.

@scolapasta
Copy link

I do think we should change the code so that if a tsv file lists a dv alias and it is not found, the upload fails. That can be a separate issue that I will open: IQSS/dataverse#8675

@scolapasta scolapasta removed their assignment May 4, 2022
@kcondon
Copy link
Contributor

kcondon commented May 5, 2022

looks good, ready for deployment

@kcondon kcondon merged commit d23689c into master May 5, 2022
@kcondon kcondon deleted the 145-nrd-metadatablock branch May 5, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadatablock for the Dataverse Collection: The Negotiation Data Repository
5 participants