Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse URL: Pretty-fied URL Has Typo #1142

Closed
mheppler opened this issue Nov 18, 2014 · 5 comments
Closed

Dataverse URL: Pretty-fied URL Has Typo #1142

mheppler opened this issue Nov 18, 2014 · 5 comments

Comments

@mheppler
Copy link
Contributor

When I was working on the ticket #1111 to apply the "pretty" URL to the Featured Dataverse links, I noticed that the "pretty" URL that is being used on the dataverse cards, points to "/view-datataverse/{alias}". There is an extra "T-A" in there. Also, see here on dvn-build.

https://dvn-build.hmdc.harvard.edu/view-datataverse/umaTop

Since we're going to need to go ahead and correct this, I would like to take this opportunity to remove "view-" from the URL as well, since it shouldn't be needed, and "dataverse" is shorter, and sweeter.

@scolapasta
Copy link
Contributor

I think this is all set, no?

@scolapasta scolapasta modified the milestones: Beta 12 - Dataverse 4.0, Dataverse 4.0: Final Jan 23, 2015
@kcondon
Copy link
Contributor

kcondon commented Jan 29, 2015

OK, typo and view is gone. Mike pointed out the dataverse url on the dataset card is not prettified so passing to Mike for cleanup.

@mheppler
Copy link
Contributor Author

mheppler commented Feb 3, 2015

Found that I also have ticket #1111 that outlines other instances of where the Pretty Faces needs to be used. Sending this back to QA to close. Will keep the other ticket for further development.

@mheppler mheppler assigned kcondon and unassigned mheppler Feb 3, 2015
mheppler added a commit that referenced this issue Feb 3, 2015
…e ID's, which don't work with the PrettyFaces URLs. [ref #1142]
@mheppler
Copy link
Contributor Author

mheppler commented Feb 3, 2015

Fixed dataverse URLs on search-include that still referenced dataverse ID's, which don't work with the PrettyFaces URLs.

Found that this bug in the search-include (as well as the "View All Datasets and Dataverses >" link hidden under the "Preview Recently Published Datasets [+]" link) were easy fixes, so I checked those in quick.

Please forgive the dup comment above.

@kcondon
Copy link
Contributor

kcondon commented Feb 3, 2015

Fixed, closing.

@kcondon kcondon closed this as completed Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants